Repository navigation
fix(message): render message instants through one shared UTC-based formatter - #5231
123123213weqw wants to merge 2 commits into
Conversation
The context-usage percent label carried fontSize: 13, below the project's 14px minimum. Raise it to 14 and pin it with a test that renders the meter past its 1% visibility threshold and asserts no inline 13px text remains in the composer. Fixes apache#4941 (revives the stale-closed apache#4940)
…rmatter The queue browser formatted store times with a hardcoded zh-CN locale in the browser's zone and dropped the milliseconds, while the message page kept a second private formatter with local getters; the same message rendered three different strings across views, none labeled with a zone. Both now go through formatMessageTime in utils/format: the instant is parsed (epoch millis on the wire, offset-less strings read as UTC like formatUtcDateTime), rendered in the viewer's timezone with milliseconds kept and the zone labeled; dense columns and the trace timeline pass zone:false so the suffix does not repeat on every row. Fixes apache#5219
|
Scoping note, per the convention from the #4458 review ("if you judge it out of scope, say so in the description"): the DLQ page ( |
|
This pull request has been automatically closed because there has been no activity for 7 days. If you would like to continue working on this, please reopen the PR with updated changes. |
|
This pull request was closed by the stale bot on 2026-10-08 (seven days without activity), not by a maintainer decision - the review below is what we had queued for it. Thanks for this. The core of it has since landed on |
Which Issue(s) This PR Fixes
Fixes #5219
Brief Description
The queue browser formatted store times with a hardcoded zh-CN locale in the browser zone and dropped the milliseconds, while the message page kept a second private formatter with local getters — the same message rendered three different strings, none zone-labeled. Both views now go through a shared
formatMessageTime: epoch millis parsed (offset-less strings read as UTC per theformatUtcDateTimeconvention), rendered in the viewer's timezone with milliseconds kept and the zone labeled; dense columns and the trace timeline passzone: false.How Did You Test This Change
npx vitest run src/utils/format.test.ts src/components/__tests__/QueueBrowser.test.tsx— new formatter cases plus a shape pin that reddens on a zh-CN revert.npx vitest run src/pages/instance/__tests__/— 197/197 green.