Repository navigation
fix(web): disclose a truncated or encoded body in the queue browser - #6871
Closed
iloveeyjafjalla wants to merge 1 commit into
Closed
iloveeyjafjalla wants to merge 1 commit into
iloveeyjafjalla wants to merge 1 commit into
Conversation
The message card of the queue browser renders entry.message.body as it arrives: a body the server cut at its display cap (64 KiB text, 48 KiB base64) or a body it could not decode as text, which it returns BASE64-encoded. Both facts are on the same record, and the card already passes propertiesTruncated to the properties panel right below, so the omission is this surface's alone: the detail modal warns about both flags for the same payload, and the tool that serves this fetch reports them as first-class output fields. The card now shows the same two notices, with the copy the detail modal uses.
|
This pull request has been automatically closed because there has been no activity for 7 days. If you would like to continue working on this, please reopen the PR with updated changes. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #6870
The defect
The queue browser's message card rendered the body payload as it arrived: a body the server cut at its display cap (64 KiB text / 48 KiB base64) or one it could not decode as text, which it returns BASE64-encoded. Both facts are on the record the card already uses — and it forwards
propertiesTruncatedto the properties panel right below — but the body itself was presented as the whole message. The detail modal warns about both flags for the same payload, and the tool serving this fetch declares them as first-class output fields.The fix
The Body card renders the same two notices the detail modal renders, with the same copy (
messagePage.bodyTruncatedWarning,messagePage.bodyBinaryWarning): a warning for a truncated body and an info notice for a base64-encoded one. No new strings, no service change.Tests
Red before the change:
The new case pulls one message with
bodyTruncated: true, bodyEncoding: 'BASE64'and asserts both notices; the existing properties-notice case keeps covering the panel below it.Green after:
Scope
Distinct from the open #5638 / merged #4870–#4872 work, which is the detail modal: that surface already discloses these flags, this one never did.