Repository navigation
Conversation
Open
4 tasks done
Contributor
Author
|
CI follow-up: 5523ddb fixes two strict expectations in Expanded verification on the updated tree: all AI page tests plus |
Absorb apache#7115 and apache#7091 into apache#7113, including combined retry recovery coverage. Co-authored-by: Codex <codex@openai.com> Signed-off-by: zmuxuny <xiahoumuxuan@gmail.com>
This was referenced Oct 20, 2026
Reuse the five-line ConsumerPage timer isolation from commit 381c5c4, credited to pilichoumao's apache#6521. Keep production polling, all existing assertions, and independent automatic-refresh coverage unchanged. Signed-off-by: zmuxuny <xiahoumuxuan@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Which Issue(s) This PR Fixes
Fixes #7109
Fixes #7112
Fixes #7088
Brief Description
This consolidates #7113, #7115, and #7091 around one transcript-ownership lifecycle: a conversation's persisted prefix and live suffix must remain one answer until history successfully takes ownership, and none of that conversation's transient display state may leak into the next conversation.
Original contributions and author attribution from all three PRs are retained. The additional integration regression exercises their common boundary: an attached split Markdown answer, failed final timeline refresh, and successful Retry must remain one answer across committed DOM changes. There are no backend, protocol, replay cursor, dependency, or unrelated UI changes.
How Did You Test This Change?
On the combined final tree:
npx vitest run src/pages/ai src/api/aiEvents.optionalFields.test.ts --pool=forks --maxWorkers=1: 23 files, 322 tests passed.npx tsc -b: passed.git diff --check: passed.This is the complete affected AI suite plus API terminal-bubble expectations, not a claim that every frontend or backend suite was run. Initial concurrent test attempts were resource-interrupted; the reported aggregate is the subsequent completed single-worker run.
Negative control: copied the final real routed AiPage test file unchanged into an independent worktree at base
127c47b06a268cc74224d5f34c56ec7c36ac0d55. Five selected regressions failed as expected: split attached Markdown, duplicated tool card, failed-refresh Retry leaving duplicate answers/error, cross-conversation speed attribution, and the combined attach/retry flow. No baseline production code was modified.Controls retained include tool-id reuse, immutable prefix/suffix inputs, different/unknown run ownership, terminal history, unread/scroll behavior, repeated and failed retry, navigation/unmount/new-run supersession, independent stream errors, and same-conversation speed fallback.
Checklist
mvn test), not run for this frontend-only changeAI assistance was used to investigate, consolidate, review, and validate this change. No live provider or cluster was contacted.
Production build:
npm run buildpassed, including TypeScript, Vite production bundle, and license check (build.log).