Repository navigation
Conversation
Contributor
Author
|
Withdrawing this standalone patch to reduce review fragmentation. The timeout classification changes structured error codes, but no in-project consumer has been demonstrated to act differently on them, and retry, budget, and exit behavior are unchanged. The patch and branch are preserved for future focused CLI diagnostics work. |
Reuse the five-line ConsumerPage timer isolation from commit 381c5c4, credited to pilichoumao's apache#6521. Keep production polling, all existing assertions, and independent automatic-refresh coverage unchanged. Signed-off-by: zmuxuny <xiahoumuxuan@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Which Issue(s) This PR Fixes
Fixes #7111
Brief Description
Classify transport errors whose
net.Error.Timeout()is true asTIMEOUT, instead of treating every network error asUNAVAILABLE. Socket/DNS deadlines need not wrapcontext.DeadlineExceeded; the existing context-only check therefore misses them.The original error message is retained, with a network/responsiveness hint. Explicit CLI/API errors, context deadlines, and cancellation keep their existing precedence. Non-timeout transport errors remain
UNAVAILABLE.How Did You Test This Change?
On unchanged production code, three normalization cases fail (socket, DNS, and wrapped socket timeout), as do actual
App.Executeregressions for table, JSON, and YAML output. All reportUNAVAILABLEinstead ofTIMEOUT. The local injected RoundTripper never contacts a server.Controls retain connection-refused, temporary non-timeout DNS, explicit CLI classification, context deadline, cancellation, and plain-error behavior.
On the final tree, with Go 1.27.1:
All passed, including catalog freshness, all module packages/scripts, and all six supported platform builds with their generated license material checks.
Checklist
Testsuffixmvn test), not run for this Go-only changeAI assistance was used for diagnosis, implementation, regression tests, independent review, and validation. No live Studio server or RocketMQ cluster was contacted.