Repository navigation
Conversation
The bulk message-property paste parser split only on LF and CRLF, so a CR-only paste such as "traceId=one\rtenant=demo" was parsed as one property whose value silently swallowed the second key=value pair. Split on CR, LF and CRLF (and any mix) so every pasted line becomes its own record. Commas and extra equals signs inside values stay intact. Fixes apache#7106
Author
|
The
I don't have permission to re-run the workflow from a fork (the API returns 404). Could a committer please re-run the failed job for run https://github.com/apache/rocketmq-dashboard/actions/runs/39276947373 ? Thanks! |
Author
|
The |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Batch-pasted message properties separated only by carriage returns (classic Mac text and some clipboard flows) were swallowed into the previous value because the parser split on
\r?\nonly. The split now treats CR, LF and CRLF alike as record separators, and a new unit test covers mixed line endings.Fixes #7106