Repository navigation
Conversation
This was referenced Oct 19, 2026
Open
Contributor
Author
|
Withdrawing this PR from the active review queue until a current consumer impact or an explicit protocol requirement is established. The current Studio page waits for event:done before its final refetch and does not consume the early terminal callback/status in a way shown to affect users. The tests demonstrate internal ordering, while the timeline-event/run-row replay window also remains outside this patch. The patch and branch are preserved for further evidence-driven work. |
Reuse the five-line ConsumerPage timer isolation from commit 381c5c4, credited to pilichoumao's apache#6521. Keep production polling, all existing assertions, and independent automatic-refresh coverage unchanged. Signed-off-by: zmuxuny <xiahoumuxuan@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Which Issue(s) This PR Fixes
Brief Description
A successful provider ResultMeta currently projects live COMPLETED before the terminal run-row update. An observer can receive success while the stored run is still RUNNING, including when that update subsequently fails.
Record successful results without projecting their terminal pair. Finalize every outcome through the existing ordered path: flush text, persist one terminal timeline event, update the run row and cache, then publish one live terminal using the recorded duration. Preserve success-before-stop and success-before-late-provider-failure precedence.
Carry the terminal event's actual sequence into the delayed publication. A reconnect that already replayed that event must not receive it again, whether its replay has finished or is still buffering live frames. The projector's standalone contract is unchanged.
Scope is live publication consistency. This does not make timeline INSERT and run-row UPDATE transactional for attach replay; the current Studio page waits for event:done before final refetch. Nearby #6385, #7031, #7044, #4999 and #6469 were reviewed for overlap. When combining with #7031, retain terminalSeq separately from any later diagnostic notice's endSeq.
AI assistance was used for investigation, implementation, and regression testing.
How Did You Test This Change?
Base: rocketmq-studio@127c47b06a268cc74224d5f34c56ec7c36ac0d55. JDK 21.0.12.1 / Maven 3.9.12.
From server/ (Mockito's explicit startup agent avoids this container's unsupported dynamic self-attachment):
MAVEN_REPO is the configured local Maven repository; proxy and existing system truststore settings were environment-only. Final bounded run took 28.57 seconds and peaked at approximately 885 MiB combined process RSS. Full backend/MySQL integration and frontend suites were not run for this two-file lifecycle fix. Independent code and test review passed.
Checklist