Skip to content

fix(instance): label inventory filters for assistive technology - #7150

Closed
zmuxuny wants to merge 2 commits into
apache:rocketmq-studiofrom
zmuxuny:fix/instance-filter-labels-oct20
Closed

zmuxuny wants to merge 2 commits into
apache:rocketmq-studiofrom
zmuxuny:fix/instance-filter-labels-oct20

Conversation

@zmuxuny

@zmuxuny zmuxuny commented Oct 19, 2026

Copy link
Copy Markdown
Contributor

Which Issue(s) This PR Fixes

Brief Description

Give both instance inventory filters accessible names using the existing English/Chinese translations. The search placeholder and selected access type currently leave the real textbox and combobox unnamed.

The regression tests render the real AntD controls in both languages and cover their names, keyboard type selection, combined search/type filtering, and clearing the search while retaining the selected type.

How Did You Test This Change?

Before the production change, both language cases failed on all four accessible-name assertions. Their keyboard and filtering checks passed. With the two labels added:

cd web
npx vitest run src/pages/instance/__tests__/InstancePage.test.tsx src/services/instanceService.test.ts src/i18n/__tests__/translations.test.ts src/i18n/__tests__/LangContext.test.tsx src/i18n/languagePreference.test.ts --pool=threads --maxWorkers=1
# 5 files passed, 62 tests passed
npx tsc -b --force
npx eslint src/pages/instance/index.tsx src/pages/instance/__tests__/InstancePage.test.tsx
npx prettier --check src/pages/instance/index.tsx src/pages/instance/__tests__/InstancePage.test.tsx
git diff --check
# All passed

Checklist

  • One coherent change; unrelated modifications are not bundled in
  • Commit subject follows Conventional Commits
  • Regression tests added with ...Test names
  • Existing English and Chinese translations reused; no new UI text
  • Architecture tests not run for this frontend-only change; no backend files changed
  • No new source files; existing ASF headers retained
  • No documented behavior changed

Base branch: rocketmq-studio.

@zmuxuny

zmuxuny commented Oct 19, 2026

Copy link
Copy Markdown
Contributor Author

Added explicit post-interaction accessible-name assertions in 007504c, following the test suggestion in #7149. Both English and Chinese cases now recheck the actual search input after typing and the access-type combobox after selection and clearing, alongside the existing request/filter assertions. This follow-up only adds four assertions; production code and existing assertions are unchanged.

The two focused language/interaction tests pass (34 unrelated cases not selected); changed-file ESLint and Prettier checks pass. The new head has its own CI run pending.

zmuxuny added a commit to zmuxuny/rocketmq-dashboard that referenced this pull request Oct 20, 2026
Consolidate apache#7104, apache#7130 and apache#7150 into apache#7163. Preserve the validated source tree and existing shared-selector commit.

Co-authored-by: Codex <codex@openai.com>
Signed-off-by: zmuxuny <xiahoumuxuan@gmail.com>
@zmuxuny

zmuxuny commented Oct 20, 2026

Copy link
Copy Markdown
Contributor Author

Consolidated into #7163 with the related accessible-name fixes and combined regression coverage. Closing this separate review to avoid duplication; the implementation is preserved in the combined PR.

@zmuxuny zmuxuny closed this Oct 20, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant