Repository navigation
Conversation
Signed-off-by: zmuxuny <xiahoumuxuan@gmail.com>
Reuse the five-line ConsumerPage timer isolation from commit 381c5c4, credited to pilichoumao's apache#6521. Keep production polling, all existing assertions, and independent automatic-refresh coverage unchanged. Signed-off-by: zmuxuny <xiahoumuxuan@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Which Issue(s) This PR Fixes
Fixes #7214
Brief Description
Invalidate the Topic configuration comparison's request generation when its component unmounts. TopicPage conditionally mounts this modal, so Close or leaving the page must also end ownership of its pending read outcomes. Otherwise a rejected inventory read displays a global failure notification over the page the operator is now using.
This adds disposal cleanup to the existing generation guard. The existing instance-pair invalidation from #4585 / #4586 is preserved. No API, inventory comparison, export, request cancellation or backend behavior changes.
How Did You Test This Change?
Added four real-component cases: source failure after unmount, target failure after unmount, an old failure after reopening and completing a new comparison, and a still-current failure under React StrictMode.
On unchanged production at 127c47b, the three abandoned-comparison cases fail and all 12 other cases pass. With the fix:
No live cluster was used. The inventory service promises are controlled; AntD and the comparison component are real. Full frontend/backend suites were not run locally; remote CI will be checked on the published commit. Independent diff review: Approved; independently reran the focused 15-case component suite.
Checklist