Repository navigation
fix(web): preserve negative numeric CSV values - #7337
Open
X-LightYear wants to merge 1 commit into
Open
X-LightYear wants to merge 1 commit into
X-LightYear wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Problem
The shared CSV helper treated every text value beginning with
-as a possible spreadsheet formula. Metric Explorer supplies parsed sample values as numbers, so negative values were exported with a leading apostrophe and opened as text.Fix
Only string-like values retain the formula-protection prefix. Numeric values are serialized without the prefix.
Testing
escapeCsvCell(-3.5)returned"'-3.5"download.test.tsandresourceCsvImport.test.ts: 26 passednpm run build: TypeScript/Vite completed; existing distribution-license verification rejected thetoggle-selectionsource/license mismatchFixes #7336