Repository navigation
fix(cloud): page consumer group inventories natively - #7339
Open
X-LightYear wants to merge 1 commit into
Open
X-LightYear wants to merge 1 commit into
X-LightYear wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Root cause
MetadataService.listConsumerGroupsPagedelegates to the provider SPI. Aliyun and Tencent didnot override
InstanceProvider.listConsumerGroupsPage, so the default implementation called thefull
listConsumerGroupspath and sliced the result in memory. Tencent's full path also performsper-group detail enrichment.
Fix
pageNumber,pageSize, and the existing search filter toListConsumerGroups.offsetandlimittoDescribeConsumerGroupListfor the unfiltered page path.PageResultcontract.Testing
201, actual total1and no page item.BusinessException: Tencent Cloud returned an incomplete consumer group page.AliyunInstanceProviderTest,TencentInstanceProviderTest: 132 passed.MetadataServiceTest: passed.python3binary-license gate (exit 9009); Javacompilation and packaging completed before that environment-only failure.
Fixes #7338