Repository navigation
Follow the weblog creation setting on save, and count every account for the first administrator - #368
Merged
Merged
Conversation
Opening the Create weblog form already refused when the site does not let users create weblogs. Saving it now checks the same setting.
With users.firstUserAdmin on, a new account became an administrator when no enabled account existed. Disabled accounts now count as well, so only the site's first account is made an administrator.
mraible
approved these changes
Nov 21, 2026
mraible
left a comment
Contributor
There was a problem hiding this comment.
Looks good. Saving now follows the same setting check as opening the form, and counting every account with the new User.getCount query means a disabled account still counts as the first one. Both are as small as they can be. I'm happy to port it to master if that helps.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Two small fixes to account and weblog creation for 6.1.8.
users.firstUserAdminon, Roller now counts disabled accounts too before making a new account an administrator.CreateWeblogSettingTestandFirstUserAdminTestfail without their change. The full 6.1.x unit suite passes on JDK 11 (817 tests).Not ported to master yet.