Repository navigation
Serve weblog pages, feeds, search and resources only through forwards - #370
Merged
Merged
Conversation
Roller forwards a weblog's public URLs to the rendering servlets. Direct requests to the page, feed, search and resources servlets now answer 404, so a weblog's content is reached only at the weblog's own addresses. Comment posts, RSD and media file links keep their direct addresses.
mraible
approved these changes
Nov 21, 2026
mraible
left a comment
Contributor
There was a problem hiding this comment.
Looks good. The filter's four patterns are the same as the PageServlet, FeedServlet, SearchServlet and ResourceServlet mappings, so any request the container hands straight to those servlets meets the filter first, and the forwards from WeblogRequestMapper and CommentServlet pass. Media resources, comments and RSD stay outside it, and I didn't find any template or JSP that links to the four paths directly.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Roller forwards a weblog's public URLs to its internal rendering servlets. This makes those forwards the only way in for weblog content.
RenderingForwardOnlyFilter, mapped for REQUEST dispatches only, covers/roller-ui/rendering/page/,feed/,search/andresources/. Forwards from the weblog's own URLs pass, so rules a site sets for those URLs apply./roller-ui/rendering/media-resources/links in entries are not filtered. Every in-code use of the four paths is a server-side forward.RenderingForwardOnlyFilterTestfails without the change. The full 6.1.x unit suite passes on JDK 11 (818 tests).Master's #300 does the equivalent in its Java security configuration.