Repository navigation
Update account forms, request limits and logging for 6.1.8 - #371
Conversation
mraible
left a comment
There was a problem hiding this comment.
The XML-RPC body cap, the 200-entry limit, the logging changes and the 72-byte check on registration and profile all look right to me. On your two questions, and one more:
- Email address in templates: I'd drop it as you have. The security model says weblog Admins can't read other users' private data, no bundled theme uses it, and CHANGES calls it out.
struts.multipart.maxSize: I'd derive it.uploads.file.maxsizeis a runtime setting a global admin can raise in Site Settings, so with a fixed 12 MiB, raising it there would make larger uploads fail with nothing pointing atstruts.properties. One option is to leave Struts' ceiling high and check the request's length in a filter on the media upload action, against five timesuploads.file.maxsizeplus room for the form, the way your XML-RPC filter does.- Admin user form:
UserEditdoesn't get the 72-byte check. Its field only hasmaxlength="30"in the browser, and Spring Security 5.8's BCrypt quietly truncates past 72 bytes, so it could use the same server-side check as Register and Profile.
Happy to approve once the multipart limit is settled.
…d length on the admin user form MultipartSizeFilter, ahead of the Struts filter, allows five files of uploads.file.maxsize plus 1 MiB of form data, so raising the setting in Site Settings raises the limit too. Struts' own ceiling goes back to its old value. The admin user form gets the same 72-byte password check as registration and profile.
|
Thanks. Both done in d6352b3:
Full unit suite passes on JDK 11 (830 tests). |
mraible
left a comment
There was a problem hiding this comment.
Thanks, both look good. The new filter runs ahead of Struts on *.rol, and ValidateSaltFilter leaves multipart requests to the Struts interceptor, so nothing reads the body before the limit applies. Counting the bytes actually read covers chunked requests too, and raising the setting in Site Settings now raises the limit. UserEdit gets the same 72-byte check as Register and Profile.
…s-and-logging-6.1.x # Conflicts: # CHANGES.md
mraible
left a comment
There was a problem hiding this comment.
Re-approving after the merge of roller-6.1.x; the CHANGES.md resolution keeps both entries.
Follow-ups from the ASVS scan of Roller, for 6.1.8.
MultipartSizeFilter, ahead of Struts, allows five files of the "Maximum file size" in Site Settings plus 1 MiB of form data (11 MiB with the default 2 MB), so it follows that setting; Struts' own ceiling is unchanged. XML-RPC request bodies are capped before parsing (1 MiB with uploads off, otherwise sized from the upload limit, at most 32 MiB). Blogger and MetaWeblog return at most 200 recent entries.Tests: new focused tests fail without the changes. The full 6.1.x unit suite passes on JDK 11 (830 tests).
A custom theme that prints
$user.emailAddress(or a visitor's) will now print nothing; CHANGES says so.