Skip to content

Update account forms, request limits and logging for 6.1.8 - #371

Merged
snoopdave merged 3 commits into
roller-6.1.xfrom
request-limits-and-logging-6.1.x
Nov 22, 2026
Merged

snoopdave merged 3 commits into
roller-6.1.xfrom
request-limits-and-logging-6.1.x

Conversation

@snoopdave

@snoopdave snoopdave commented Nov 21, 2026 •

Copy link
Copy Markdown
Contributor

Follow-ups from the ASVS scan of Roller, for 6.1.8.

  • Accounts and templates. Registration, profile and the admin user form take passwords up to 72 UTF-8 bytes, checked on the server. The user and visitor objects in templates no longer provide an email address; bundled themes don't use it.
  • Limits. A new MultipartSizeFilter, ahead of Struts, allows five files of the "Maximum file size" in Site Settings plus 1 MiB of form data (11 MiB with the default 2 MB), so it follows that setting; Struts' own ceiling is unchanged. XML-RPC request bodies are capped before parsing (1 MiB with uploads off, otherwise sized from the upload limit, at most 32 MiB). Blogger and MetaWeblog return at most 200 recent entries.
  • Logging. Configuration debug messages show property names, not values, and weblog lookup errors print the handle on one line.

Tests: new focused tests fail without the changes. The full 6.1.x unit suite passes on JDK 11 (830 tests).

A custom theme that prints $user.emailAddress (or a visitor's) will now print nothing; CHANGES says so.

@mraible mraible left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The XML-RPC body cap, the 200-entry limit, the logging changes and the 72-byte check on registration and profile all look right to me. On your two questions, and one more:

  • Email address in templates: I'd drop it as you have. The security model says weblog Admins can't read other users' private data, no bundled theme uses it, and CHANGES calls it out.
  • struts.multipart.maxSize: I'd derive it. uploads.file.maxsize is a runtime setting a global admin can raise in Site Settings, so with a fixed 12 MiB, raising it there would make larger uploads fail with nothing pointing at struts.properties. One option is to leave Struts' ceiling high and check the request's length in a filter on the media upload action, against five times uploads.file.maxsize plus room for the form, the way your XML-RPC filter does.
  • Admin user form: UserEdit doesn't get the 72-byte check. Its field only has maxlength="30" in the browser, and Spring Security 5.8's BCrypt quietly truncates past 72 bytes, so it could use the same server-side check as Register and Profile.

Happy to approve once the multipart limit is settled.

…d length on the admin user form

MultipartSizeFilter, ahead of the Struts filter, allows five files of
uploads.file.maxsize plus 1 MiB of form data, so raising the setting in
Site Settings raises the limit too. Struts' own ceiling goes back to its
old value. The admin user form gets the same 72-byte password check as
registration and profile.
@snoopdave

Copy link
Copy Markdown
Contributor Author

Thanks. Both done in d6352b3:

  • Multipart limit: struts.multipart.maxSize is back to its old value. A new MultipartSizeFilter, mapped on *.rol ahead of Struts, allows five files of uploads.file.maxsize plus 1 MiB, checks the declared length and counts the bytes actually read. So raising the setting in Site Settings raises the limit.
  • Admin user form: UserEdit now has the same 72-byte check, and the field's maxlength is 72.

Full unit suite passes on JDK 11 (830 tests).

@snoopdave
snoopdave requested a review from mraible November 21, 2026 23:12

@mraible mraible left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, both look good. The new filter runs ahead of Struts on *.rol, and ValidateSaltFilter leaves multipart requests to the Struts interceptor, so nothing reads the body before the limit applies. Counting the bytes actually read covers chunked requests too, and raising the setting in Site Settings now raises the limit. UserEdit gets the same 72-byte check as Register and Profile.

…s-and-logging-6.1.x

# Conflicts:
#	CHANGES.md
@snoopdave
snoopdave requested a review from mraible November 21, 2026 23:42

@mraible mraible left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Re-approving after the merge of roller-6.1.x; the CHANGES.md resolution keeps both entries.

@snoopdave
snoopdave merged commit 05a33b3 into roller-6.1.x Nov 22, 2026
7 checks passed
@snoopdave
snoopdave deleted the request-limits-and-logging-6.1.x branch November 22, 2026 12:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants