Clean up page titles, render from frontmatter#696
Conversation
|
Many page headings are set one level too deep. I can correct these in this PR as well, but wanted to start with a more contained set of changes first. |
|
I'll look into the build failure. One thing I'm wondering is: Why don't we have a GitHub Actions workflow generate the docs and push to |
|
If any committers think it's a good idea, I would be happy to look into reworking the setup of this repo as follows:
I think this in theory gets us the ideal workflow:
|
|
I think this is a good idea! BTW do we have to split into two branches? The GA job can generate html and commit to the same branch? |
|
We could leave it all on one branch like it is right now and just have Actions build the site for us. It doesn't solve the problem of diff noise, however. But if we want a more conservative approach, we could do that. Better would be to split the source from the rendered output on two separate branches so that a PR like this has a proper diff illustrating my actual source changes, without the added noise of the rendered output diff. Specifically, for this PR:
With one branch these diffs will always be mixed together. With two branches, we can keep them totally separate. |
|
automatically generating html files is already a big improvement, we can filter out html only commits manually if needed, I don't think that's a big advantage, as mostly people only look at PRs, not merged commits. |
|
I agree most of the time we are looking at PRs. But it is still a big advantage IMO when the local git status, remote git history, and repo structure all show only source changes. It just makes the whole repository look and work more like a "normal" one, and there is no need to ever think about filtering out noise. I have been reading up on .asf.yaml and how we can test changes on a staging site (FYI: we already have one), automatically build the HTML, etc. I have a plan to get us to a source-only On the other hand, I know this repo is not exactly the most exciting part of the project. So if you want to do something more conservative that is easier to review, I understand. |
|
I'd vote for single branch to avoid the new education cost for people contributing to this repo. |

Clean up the site titles as follows:
h1if it's defined in the page's frontmatter.singularpage type, which is no longer needed.I rendered and reviewed the built docs locally.