[MINOR][SS] Use filterNot in HDFSBackedStateStoreProvider snapshot filtering#57519
Open
uros-b wants to merge 1 commit into
Open
[MINOR][SS] Use filterNot in HDFSBackedStateStoreProvider snapshot filtering#57519uros-b wants to merge 1 commit into
uros-b wants to merge 1 commit into
Conversation
dongjoon-hyun
approved these changes
Jul 25, 2026
dongjoon-hyun
left a comment
dongjoon-hyun
left a comment
Member
There was a problem hiding this comment.
+1, LGTM.
BTW, if you want to backport this to branch-4.x for Spark 4.3.0, you had better get a new JIRA ID.
Otherwise, this is only for Apache Spark 5.0.0 (master).
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
Replaces
filter(_.isSnapshot == false)with the equivalent, idiomaticfilterNot(_.isSnapshot)inHDFSBackedStateStoreProvider.doSnapshot.Why are the changes needed?
StoreFile.isSnapshotis a plainBooleanfield, so comparing it tofalseis redundant.filterNotis the idiomatic form used throughout Spark and reads more clearly.Does this PR introduce any user-facing change?
No.
How was this patch tested?
Behavior-preserving one-line change; existing state-store tests cover the path. No new tests needed.
Was this patch authored or co-authored using generative AI tooling?
Generated-by: Claude Code (Opus 4.8)