[SYSTEMDS-3857] set get names on dataframes - #2495
Open
t99-i wants to merge 18 commits into
Open
Conversation
added 5 commits
June 14, 2026 17:36
This patch adds the language references for the newly implemented getName and setName function. The order in Builtins.java was fixed to be alphabetical again
t99-i
changed the title
janniklinde
requested changes
Jun 24, 2026
janniklinde
left a comment
janniklinde
left a comment
Contributor
There was a problem hiding this comment.
Thanks for the PR @t99-i. I left some comments in the code that should be addressed.
In general, please configure your IDE to use tabs instead of spaces. Also, please remove the unnecessary TODO comments.
As a next step, please implement support for the spark backend and add the according tests. In general, you should have a more systematic approach to verifying metatdata propagation through tests as you currently only include cbind/rbind/slice for the CP backend (should be extended to spark backend and should test other frame related functions systematically).
github-project-automation
Bot
moved this from In Progress
to In Review
in SystemDS PR Queue
added 3 commits
July 7, 2026 22:12
- fixed mapping of binarOP in DMLTranslator - added size/data validation in BinaryFrameFrameCPInstruction - setName does now have a STRING return type - removed duplicated code - fixed get/set-swap - removed unnecessary prints in FrameColumnNamesTest - removed unnecessary TODOs
- added SetName functionality for SPARK - extended propagation test (wip) - added Set/GetNames function tests for SPARK
t99-i
marked this pull request as draft
July 19, 2026 13:19
added 8 commits
July 19, 2026 15:39
- Adapted BuiltinNarySPInstruction to carry over columnNames on FrameBlocks - Removed SetColumnNamesFunction from FrameAppendRSPInstruction - Adapted MLContextConversionUtil to carry over columnNames on FrameBlocks - Adapted ParameterizedBuiltinFEDInstruction to carry over schema and columnNames on FrameBlocks - Adapted ParameterizedBuiltinFEDInstruction to carry over schema and columnNames on FrameBlocks
- replaced the setColumnMetadata function in FrameBlock with a deep copy variant
- small fix in the FrameColNamesPropagationTest
- added dml file for left Indexing test
- added a readme for the student project
…et-names-on-dataframes # Conflicts: # src/main/java/org/apache/sysds/runtime/controlprogram/caching/FrameObject.java
t99-i
marked this pull request as ready for review
August 2, 2026 12:46
- removed unused function
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR adds the frame operations getNames and setNames.
Changes:
Tests:
The propagation tests verify that column names are preserved correctly during frame operations. The covered operations are cbind, rbind, and slice.
The tests use frame dimensions ranging from 10 to 1000 columns.
Note:
I observed unusual column-name propagation behavior for cbind on wider frames around 3000 columns. I left this case out of the regression tests to keep the PR focused on getNames/setNames and the CP runtime scope.