Project: S3779 LZW ColGroup | ASML

[MasterBrain2000]

Group Project for the AMLS Module

[janniklinde]

Your code does not build (see error logs). Could you please fix those issues to have a prototype that compiles?

[janniklinde]

@MasterBrain2000 @m-ollka @Mancer1 could you please address the issues causing the tests to fail? Thanks

[Mancer1]

@janniklinde, all the build problems have been addressed.

[codecov]

Codecov Report

❌ Patch coverage is 32.15548% with 576 lines in your changes missing coverage. Please review.
✅ Project coverage is 71.41%. Comparing base (d5f6950) to head (1298867).
⚠️ Report is 15 commits behind head on main.

Files with missing lines	Patch %	Lines
...ss/colgroup/ColGroupPiecewiseLinearCompressed.java	23.86%	506 Missing and 14 partials ⚠️
...ress/colgroup/functional/PiecewiseLinearUtils.java	59.85%	51 Missing and 4 partials ⚠️
...he/sysds/runtime/compress/colgroup/ColGroupIO.java	0.00%	1 Missing ⚠️

Additional details and impacted files

@@             Coverage Diff              @@
##               main    #2560      +/-   ##
============================================
- Coverage     71.61%   71.41%   -0.20%     
- Complexity    50132    50432     +300     
============================================
  Files          1614     1628      +14     
  Lines        193986   195507    +1521     
  Branches      37935    38172     +237     
============================================
+ Hits         138925   139626     +701     
- Misses        44155    44939     +784     
- Partials      10906    10942      +36     

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:

• ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
• 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

[Mancer1]

@janniklinde, for code coverage, aren't tests considered part of it? We have some helper functions from the old DP algorithm, and we used to test them against the new algorithm. These DP helper functions are not used anywhere other than the tests we wrote.

[Mancer1]

@janniklinde, How much code coverage is accepted? We have some null functions that are required to be implemented but never called.

[janniklinde]

Generally, all functions that are expected to provide a working implementation should be tested, @Mancer1. Coverage also includes nested function calls, so you should be able to achieve high coverage by testing the publicly available functions of the compressed column group. Please use the tests for existing AColGroup implementations as a reference.

Also, please avoid reimplementing helper functionality that is already available in the test utilities, such as random matrix generation.