Skip to content

TEZ-4739: Improve ACLManager#524

Open
abstractdog wants to merge 2 commits into
apache:masterfrom
abstractdog:TEZ-4739
Open

TEZ-4739: Improve ACLManager#524
abstractdog wants to merge 2 commits into
apache:masterfrom
abstractdog:TEZ-4739

Conversation

@abstractdog

Copy link
Copy Markdown
Contributor

No description provided.

return;
}
if (aclInfo == null) {
return;

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nit:

if (!aclsEnabled || aclInfo == null) {
      return;
    }

@Aggarwal-Raghav Aggarwal-Raghav left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM +1

@Aggarwal-Raghav Aggarwal-Raghav left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM +1

@tez-yetus

Copy link
Copy Markdown

💔 -1 overall

Vote Subsystem Runtime Logfile Comment
+0 🆗 reexec 9m 26s Docker mode activated.
_ Prechecks _
+1 💚 dupname 0m 0s No case conflicting files found.
+0 🆗 detsecrets 0m 0s detect-secrets was not available.
+1 💚 @author 0m 0s The patch does not contain any @author tags.
+1 💚 test4tests 0m 0s The patch appears to include 1 new or modified test files.
_ master Compile Tests _
+1 💚 mvninstall 5m 4s master passed
+1 💚 compile 4m 0s master passed
+1 💚 checkstyle 0m 34s master passed
+1 💚 javadoc 0m 42s master passed
+0 🆗 spotbugs 1m 22s tez-api in master has 92 extant spotbugs warnings.
_ Patch Compile Tests _
+1 💚 mvninstall 4m 1s the patch passed
+1 💚 codespell 1m 46s No new issues.
+1 💚 compile 4m 1s the patch passed
+1 💚 javac 4m 1s the patch passed
+1 💚 blanks 0m 1s The patch has no blanks issues.
+1 💚 checkstyle 0m 26s the patch passed
+1 💚 javadoc 0m 40s the patch passed
+1 💚 spotbugs 1m 34s the patch passed
_ Other Tests _
-1 ❌ unit 75m 39s /patch-unit-root.txt root in the patch passed.
+1 💚 asflicense 0m 29s The patch does not generate ASF License warnings.
111m 32s
Reason Tests
Failed junit tests tez.test.TestAMRecovery
Subsystem Report/Notes
Docker ClientAPI=1.55 ServerAPI=1.55 base: https://ci-hadoop.apache.org/job/tez-multibranch/job/PR-524/1/artifact/out/Dockerfile
Optional Tests dupname compile unit asflicense javac javadoc spotbugs checkstyle codespell detsecrets
uname Linux 474a98e873e0 5.15.0-185-generic #195-Ubuntu SMP Fri Jun 19 17:11:50 UTC 2026 x86_64 x86_64 x86_64 GNU/Linux
Build tool maven
Personality tez-personality.sh
git revision master / b9d8c0f
Default Java Eclipse Adoptium-21.0.11+10-LTS
Test Results https://ci-hadoop.apache.org/job/tez-multibranch/job/PR-524/1/testReport/
Max. process+thread count 2103 (vs. ulimit of 5500)
modules C: tez-api U: tez-api
Console output https://ci-hadoop.apache.org/job/tez-multibranch/job/PR-524/1/console
versions git=2.43.0 maven=3.9.15 spotbugs=4.9.3 codespell=2.4.1
Powered by Apache Yetus 0.15.1 https://yetus.apache.org

This message was automatically generated.

@tez-yetus

Copy link
Copy Markdown

🎊 +1 overall

Vote Subsystem Runtime Logfile Comment
+0 🆗 reexec 3m 51s Docker mode activated.
_ Prechecks _
+1 💚 dupname 0m 0s No case conflicting files found.
+0 🆗 detsecrets 0m 0s detect-secrets was not available.
+1 💚 @author 0m 0s The patch does not contain any @author tags.
+1 💚 test4tests 0m 0s The patch appears to include 1 new or modified test files.
_ master Compile Tests _
+1 💚 mvninstall 3m 4s master passed
+1 💚 compile 2m 34s master passed
+1 💚 checkstyle 0m 24s master passed
+1 💚 javadoc 0m 26s master passed
+0 🆗 spotbugs 0m 49s tez-api in master has 92 extant spotbugs warnings.
_ Patch Compile Tests _
+1 💚 mvninstall 2m 15s the patch passed
+1 💚 codespell 0m 50s No new issues.
+1 💚 compile 2m 36s the patch passed
+1 💚 javac 2m 36s the patch passed
+1 💚 blanks 0m 0s The patch has no blanks issues.
+1 💚 checkstyle 0m 18s the patch passed
+1 💚 javadoc 0m 28s the patch passed
+1 💚 spotbugs 0m 57s the patch passed
_ Other Tests _
+1 💚 unit 59m 24s root in the patch passed.
+1 💚 asflicense 0m 22s The patch does not generate ASF License warnings.
79m 19s
Subsystem Report/Notes
Docker ClientAPI=1.55 ServerAPI=1.55 base: https://ci-hadoop.apache.org/job/tez-multibranch/job/PR-524/2/artifact/out/Dockerfile
Optional Tests dupname compile unit asflicense javac javadoc spotbugs checkstyle codespell detsecrets
uname Linux d03c04e47a51 5.15.0-179-generic #189-Ubuntu SMP Tue May 5 18:20:56 UTC 2026 x86_64 x86_64 x86_64 GNU/Linux
Build tool maven
Personality tez-personality.sh
git revision master / b9d8c0f
Default Java Eclipse Adoptium-21.0.11+10-LTS
Test Results https://ci-hadoop.apache.org/job/tez-multibranch/job/PR-524/2/testReport/
Max. process+thread count 1525 (vs. ulimit of 5500)
modules C: tez-api U: tez-api
Console output https://ci-hadoop.apache.org/job/tez-multibranch/job/PR-524/2/console
versions git=2.43.0 maven=3.9.15 spotbugs=4.9.3 codespell=2.4.1
Powered by Apache Yetus 0.15.1 https://yetus.apache.org

This message was automatically generated.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants