[ZEPPELIN-6425] Migrate zeppelin-react ESLint config to v9 flat format#5263
Merged
tbonelee merged 3 commits intoJun 3, 2026
Merged
Conversation
voidmatcha
force-pushed
the
fix/zeppelin-react-eslint-config
branch
from
a17c2ac to
af888da
Compare
voidmatcha
force-pushed
the
fix/zeppelin-react-eslint-config
branch
from
af888da to
8c7ec9c
Compare
tbonelee
requested changes
Jun 3, 2026
Contributor
tbonelee
left a comment
tbonelee
left a comment
There was a problem hiding this comment.
LGTM. We only need to correct the reference for the .eslintrc.json in zeppelin-react/README.md
tbonelee
approved these changes
Jun 3, 2026
Contributor
|
Merged into master |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What is this PR for?
This regression surfaced after ZEPPELIN-6421 (zeppelin-react lint integration) and ZEPPELIN-6424 (Angular 13 to 21 upgrade) merged in close succession. Each PR passed CI in isolation, but together they broke
npm run lint:react:projects/zeppelin-react/package.jsonscripts that use the ESLint 8--ext .ts,.tsxflag and rely onprojects/zeppelin-react/.eslintrc.json.--extand dropped.eslintrc.*support entirely in favor of flat config (eslint.config.{js,mjs,cjs}).The two changes never collided in their own PR CIs because each was tested against a master that didn't yet contain the other. Once both landed, master's
frontend / run-playwright-e2e-tests (auth, 3.9)and(anonymous, 3.9)started failing at thenpm lintstep before Playwright ran.What type of PR is it?
Bug Fix
Todos
What is the Jira issue?
ZEPPELIN-6425
How should this be tested?
Screenshots (if appropriate)
Questions: