fix(doctrine): keep zero-backed enum filter values - #8515
Merged
Conversation
ousamabenyounes
force-pushed
the
fix/issue-8475
branch
from
September 8, 2026 19:55
30f76f9 to
0a11e3a
Compare
Member
|
thanks! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix #8475
BackedEnumFilternormalized integer-backed enum query values before checking whether any valid values remained. The defaultarray_filter()callback also removed the valid integer value0, causing the filter to be silently skipped.This keeps every normalized value except
null, which is the sentinel returned for invalid enum values. A regression test covers zero and confirms negative values remain supported.Test verification (RED → GREEN)
On unmodified
4.3, the new test failed for the zero-backed case:With the fix:
Full local suite
Command:
./run-ci.sh(Doctrine ORMBackedEnumFilterTeston PHP 8.4 and PHP 8.5, matching the affected component CI job).Result: same-or-better than the upstream baseline, with no new failures, skips, ignores, or errors.