test: repair the Playwright suite - #6
Merged
Conversation
esm.sh/run now compiles JSX with the automatic runtime and emits
`import { jsx } from "react/jsx-runtime"`. The import maps declared `react`
but not `react/`, so react, swr, tanstack-query, mercure and github threw
before issuing a single request.
swr was mapped unpinned; esm.sh serves 2.5.1, which pulls react 19 next to
the pages react-dom 18 — two React copies, null hook dispatcher. Pinned to
swr@2.2.5?deps=react@18.2.0, matching tanstack-query.html.
The lock also held @playwright/test 1.44.0; regenerated to 1.62.1. The
manifest already declared ^1.44.0, which permits it, so it is untouched.
/authors/3 returned {"@id": "/authors/2"}. No test asserted the wrong value,
and mercure.html has an Author 3 button nothing ever clicks, so it went
unnoticed.
BySplashGm
marked this pull request as ready for review
September 4, 2026 12:43
soyuka
changed the title
Member
|
I renamed fix => test scope (conventional commits) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The Playwright suite was failing before any of the Mercure 1.0 work, for reasons that
have nothing to do with Mercure. This restores it, and is mergeable on its own.
Import maps no longer resolve the JSX runtime
react.html,swr.html,tanstack-query.html,mercure.htmlandgithub.htmldeclared
@jsxImportSourceandreactin their import map, but notreact/.esm.sh/runnow compiles JSX with the automatic runtime and emitsimport { jsx } from "react/jsx-runtime", which the map cannot resolve — so thosepages threw before issuing a single request. Adding
"react/": "https://esm.sh/react@18.2.0/"fixes all five.swr pulled a second React
swr.htmlmappedswrunpinned. esm.sh now serves swr 2.5.1, which depends onreact 19, next to the page's react-dom 18: two React copies, so hooks read a null
dispatcher. Pinned to
https://esm.sh/swr@2.2.5?deps=react@18.2.0, which is whattanstack-query.htmlalready did.Lockfile held @playwright/test 1.44.0
Regenerated to 1.62.1.
package.jsonalready declared^1.44.0, which permits it,so the manifest is untouched. 1.62.1 raises
engines.nodeto>=20; every workflowhere runs
node-version: lts/*, so nothing is left behind.An author fixture claimed to be another author
tests-server/fixtures/authors/3.jsonldreturned{"@id": "/authors/2"}. Nothingasserted the wrong value and the Author 3 button in
mercure.htmlis never clicked,so it went unnoticed. Nothing in this PR reads it either — the fix is here because the
data is wrong on its own terms, and it unblocks a later test that does dispatch on
@id.Verification. These fixes were validated as part of the full Mercure 1.0 stack
(6/6), not in isolation against a 0.x hub.