fix: keep GraphQL variables in the documented JS SDK call

[HarshMN2345]

What does this PR do?

The JS SDKs (web, node, react-native) drop variables from the GraphQL call shown in the Appwrite docs.

graphql.query and graphql.mutation take a single free-form object parameter named query. The params-object overload is selected when 'query' in paramsOrFirst, and a GraphQL request object has a query key as well, so the documented call is read as the params form:

graphql.mutation({
    query: 'mutation CreateAccount($email: String!) { ... }',
    variables: { email: '...' },
});

Before:

{"query":"mutation CreateAccount($email: String!) { ... }"}

After:

{"query":{"query":"mutation CreateAccount($email: String!) { ... }","variables":{"email":"..."}}}

Current Appwrite servers answer the flat body with HTTP 500 (appwrite/appwrite#13605 turns it into a 400), so every documented GraphQL call fails with the current SDKs.

When a method's only parameter is a free-form object, getOverloadCondition now adds typeof paramsOrFirst.<name> !== 'string'. Generated from the Appwrite 2.0.x spec, this operand in graphql.query and graphql.mutation is the only change in web, node and react-native:

             'query' in paramsOrFirst &&
+            typeof paramsOrFirst.query !== 'string'

The params form ({ query: { query, variables } }, { query: [...] }), positional batches, { query: null } and the Missing required parameter throw for { query: undefined } behave as before. The documented shape resolves to the positional overload, which stays marked @deprecated.

Test Plan

• Generated web (client), node (server) and react-native (client) from open-api3-2.0.x.json before and after the change: only src/services/graphql.ts differs.
• npm run format:check, lint, analyse and build pass for all three; npm run test passes for node (832 tests).
• Ran the generated graphql.ts before and after with a recording client and replayed the web payloads against an Appwrite server: the documented mutation reaches the resolver with its variables, and the documented query returns data instead of HTTP 500.
• vendor/bin/phpunit --testsuite Generation, phpcs and rector --dry-run pass.
• e2e: a general.createQuery fixture takes a lone free-form query object; the node, web and react-native scripts call it with { query, variables } and { query: { query } }, and the mock echoes what it received. Node20 and WebNode pass; with Web.php reverted, Node20 fails with Invalid `query` param: Value must be a valid object.

[greptile-apps]

Confidence Score: 5/5

The PR appears safe to merge; the overload correction is covered through observable request behavior across all affected SDK targets.

Findings

1.  Missing behavior coverage ▶

Fix with agent prompt

### Issue 1
src/SDK/Language/Web.php:1076-1078
This subtle overload-dispatch fix affects every SDK inheriting Web behavior, but no automated test exercises a lone free-form object through the documented GraphQL call or verifies that `variables` reaches the request body. Add a runtime behavior test using the generated SDK and a recording or mock client. An assertion against the emitted condition would only mirror the implementation and would not protect the actual request contract.

Note: If this suggestion doesn't match your team's coding style, reply to this and let me know. I'll remember it for next time!

---

For each issue above, determine whether it is valid and should be fixed. If so, fix it directly.

Summary

• Adds a string-value discriminator to the generated params-object overload condition.
• Adds a mock endpoint and OpenAPI fixture for a lone free-form object parameter.
• Adds observable end-to-end request-payload coverage for Web, Node, and React Native runtimes.

_{Reviews (2) · Last reviewed commit: "test: cover a lone object param that car..."}

[greptile-apps]

Missing behavior coverage

This subtle overload-dispatch fix affects every SDK inheriting Web behavior, but no automated test exercises a lone free-form object through the documented GraphQL call or verifies that variables reaches the request body. Add a runtime behavior test using the generated SDK and a recording or mock client. An assertion against the emitted condition would only mirror the implementation and would not protect the actual request contract.

Knowledge Base Used: Generation quality assurance

Prompt To Fix With AI

This is a comment left during a code review.
Path: src/SDK/Language/Web.php
Line: 1076-1078

Comment:
**Missing behavior coverage**

This subtle overload-dispatch fix affects every SDK inheriting Web behavior, but no automated test exercises a lone free-form object through the documented GraphQL call or verifies that `variables` reaches the request body. Add a runtime behavior test using the generated SDK and a recording or mock client. An assertion against the emitted condition would only mirror the implementation and would not protect the actual request contract.

**Knowledge Base Used:** [Generation quality assurance](https://app.greptile.com/appwrite/-/custom-context/knowledge-base/appwrite/sdk-generator/-/docs/generation-quality-assurance.md)

---

For each issue above, determine whether it is valid and should be fixed. If so, fix it directly.

Note: If this suggestion doesn't match your team's coding style, reply to this and let me know. I'll remember it for next time!