Skip to content

chore(deps): update sdk template dependencies - #1898

Closed
renovate-appwrite[bot] wants to merge 6 commits into
mainfrom
renovate/sdk-template-dependencies
Closed

renovate-appwrite[bot] wants to merge 6 commits into
mainfrom
renovate/sdk-template-dependencies

Conversation

@renovate-appwrite

@renovate-appwrite renovate-appwrite Bot commented Sep 11, 2026

Copy link
Copy Markdown
Contributor

This PR contains the following updates:

Package Change Age Confidence
@types/node (source) 26.4.126.5.0 age confidence
typescript-eslint (source) 8.69.08.70.0 age confidence

Release Notes

typescript-eslint/typescript-eslint (typescript-eslint)

v8.70.0

Compare Source

🩹 Fixes
  • eslint-plugin: [no-deprecated] report deprecated imported values used in object shorthand properties (#​12780)
❤️ Thank You

See GitHub Releases for more information.

You can read about our versioning strategy and releases on our website.


Configuration

📅 Schedule: (UTC)

  • Branch creation
    • At any time (no schedule defined)
  • Automerge
    • At any time (no schedule defined)

🚦 Automerge: Disabled by config. Please merge this manually once you are satisfied.

Rebasing: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox.

👻 Immortal: This PR will be recreated if closed unmerged. Get config help if that's undesired.


  • If you want to rebase/retry this PR, check this box

This PR has been generated by Mend Renovate.

CI fixes and verification

  • Preserved Renovate dependency updates and the CLI watcher race fix (31ba6e184). The deterministic test covers same-content truncate/rewrite, actual empty-file edits, and pending shutdown.
  • Reverted the Kakao/TikTok OAuth compatibility workaround and its tests in 018d7ea85, at maintainer request. CLI console validation remains blocked on a Go SDK release exposing those methods; no compatibility workaround is intended in this PR.
  • After the revert: regenerated CLI; generated gofmt check and go test -mod=mod ./internal/watch passed. Full CLI compilation/validation is not claimed passing while the SDK release is missing.
  • Before the revert, full CI and Validation passed with the now-removed workaround. These are historical results, not verification of the current head.
  • The original PHP Rector failure passed on rerun without a PHP source/dependency change. This PR has not been merged.

@renovate-appwrite renovate-appwrite Bot added the dependencies Pull requests that update a dependency file label Sep 11, 2026
@greptile-apps

greptile-apps Bot commented Sep 11, 2026

Copy link
Copy Markdown
Contributor

RetriggerConfidence Score: 5/5

The PR appears safe to merge because no actionable new defect or outstanding previous finding remains.

Fix All in Claude CodeFindings

  1. P2 Test Mirrors Fallback Internals
  2. P2 Test Recreates Watcher Internals
Fix with agent prompt
### Issue 1
templates/cli/internal/app/fallback_test.go.twig:26-60
This test bypasses the generated commands and calls the fallback helper with hand-built paths and parameter maps. It also hard-codes routes and headers and reads the internal `sdk.LastResponse` state. As a result, it can pass even if command generation produces the wrong flags or request parameters. This violates the repository directive to test observable behavior rather than mirror source code and configuration. The repository requirement must be satisfied before merging by testing the generated Kakao and TikTok commands through their public CLI surface.

Note: If this suggestion doesn't match your team's coding style, reply to this and let me know. I'll remember it for next time!

### Issue 2
templates/cli/internal/watch/watch_test.go:66-92
This test manually constructs private `Watcher` state, seeds the fingerprint cache, injects synthetic fsnotify events, calls `run` directly, and advances time using the production `settleDelay` constant. Harmless debounce refactors can therefore break the test, while failures in the public `Start` integration can remain undetected. This violates the repository directive to test observable behavior rather than mirror source code and configuration. The repository requirement must be satisfied before merging by exercising the watcher through its public interface.

Note: If this suggestion doesn't match your team's coding style, reply to this and let me know. I'll remember it for next time!

---

For each issue above, determine whether it is valid and should be fixed. If so, fix it directly.

Summary

  • Updates @types/node and typescript-eslint template dependencies.
  • Regenerates Node, web, and React Native lockfile metadata.
  • Coalesces filesystem events before fingerprinting changed files.
  • Uses Go SDK v7.3.0 for generated CLI clients.

Reviews (5) · Last reviewed commit: "Merge branch 'main' into renovate/sdk-te..."

Comment thread templates/cli/internal/app/fallback_test.go.twig Outdated
Comment thread templates/cli/internal/watch/watch_test.go
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

dependencies Pull requests that update a dependency file

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant