Repository navigation
packages: show build log link for all packages with build ID - #757
Open
reginaldalfret wants to merge 1 commit into
Open
reginaldalfret wants to merge 1 commit into
reginaldalfret wants to merge 1 commit into
Conversation
Currently, the build log link was only displayed if the package was marked as non-reproducible (RebuilderdStatus.BAD). However, the build log is valuable for reproducible packages as well, e.g. to inspect build options and environment used during build time. Display the build log link whenever rbstatus and rbstatus.build_id are present, and conditionally append the diffoscope link only when the package is not reproducible. Also remove an extraneous stray <tr> tag inside the <ul> action list. Fixes archlinux#611 Signed-off-by: reginaldalfret <reginaldalfret@gmail.com>
Member
|
Please don't paste LLM output in your pull request its unnecessarily verbose |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Show the rebuilderd build log link for all packages that have a build ID, rather than only non-reproducible packages.
Also clean up a stray <tr>\ tag inside the action <ul>\ and add unit test coverage for reproducible vs non-reproducible build log and diffoscope links.
Fixes #611