fix: use match.groupdict().get() to prevent IndexError on malformed format#1327
Open
fazalpsinfo-cmyk wants to merge 2 commits into
Open
fix: use match.groupdict().get() to prevent IndexError on malformed format#1327fazalpsinfo-cmyk wants to merge 2 commits into
fazalpsinfo-cmyk wants to merge 2 commits into
Conversation
…ormat match.group(token) raises IndexError when the token doesn't correspond to a regex named group. Using match.groupdict().get(token) returns None instead, which is already handled by the existing ParserMatchError check. Fixes arrow-py#1191
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #1327 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 10 10
Lines 2315 2315
Branches 358 358
=========================================
Hits 2315 2315 ☔ View full report in Codecov by Harness. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix: Use match.groupdict().get() to prevent IndexError on malformed format
Issue: #1191 —
match.group(token)raisesIndexError: no such groupwhen a malformed format string is used.Fix: Changed
match.group(token)tomatch.groupdict().get(token)which returnsNonefor non-existent groups. The existingParserMatchErrorcheck on line 432 already handles theNonecase gracefully.Change: 1 line in
arrow/parser.py.If you found this fix useful, consider supporting the work at https://buymeacoffee.com/muhamedfazalps