Add partial identity join sorting test#778
Open
jechol wants to merge 1 commit into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Adds a regression test for sorting a
many_to_manyrelationship by a join resource attribute when the join resource uses a partial identity.This covers the behavior fixed in ash-project/ash#2746.
The test uses a polymorphic join resource shape where multiple nullable foreign keys can exist on the same resource, but only the
post_id/user_idpair is unique when both keys are present:The loaded relationship then sorts through the join relationship field:
Notes
This test fixture mirrors polymorphic ordered join resources where a partial identity guarantees one join row for a specific source/destination pair.
Contributor checklist
Leave anything that you believe does not apply unchecked.