Skip to content

rest_api/channels: Add test for whispering with no underlying stream - #139

Open
mbradeen wants to merge 1 commit into
asterisk:masterfrom
mbradeen:master-issue-1966
Open

rest_api/channels: Add test for whispering with no underlying stream#139
mbradeen wants to merge 1 commit into
asterisk:masterfrom
mbradeen:master-issue-1966

Conversation

@mbradeen

@mbradeen mbradeen commented Jun 2, 2026

Copy link
Copy Markdown
Contributor

Adds a test to detect whispered audio when there is no underlying
stream being sent to the channel.

@mbradeen

mbradeen commented Jun 2, 2026 •
edited
Loading

Copy link
Copy Markdown
Contributor Author

cherry-pick-to: 24
cherry-pick-to: 23
cherry-pick-to: 22
cherry-pick-to: 20

@github-actions

github-actions Bot commented Jun 2, 2026

Copy link
Copy Markdown

Workflow Check failed
master-build-check-47: cherryPick.sh: Error getting commits for PR 1966. Retrying
master-build-check-47: cherryPick.sh: Error getting commits for PR 1966. Retry failed.

jcolp
jcolp requested changes Jun 3, 2026
View reviewed changes

@jcolp jcolp left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't like "nostream" as a name because there is a negotiated stream so a stream does exist, there's just no audio flowing over it. So how about snoop_whisper_no_normal_flowing_audio?

@mbradeen
rest_api/channels: Add test for whispering with no underlying stream
621b1df 
Adds a test to detect whispered audio when there is no underlying
stream being sent to the channel.
@mbradeen
mbradeen force-pushed the master-issue-1966 branch from 0d9fd6e to 621b1df Compare June 3, 2026 20:09
@github-actions

github-actions Bot commented Jun 3, 2026

Copy link
Copy Markdown

Workflow Check failed
master-build-check-49: cherryPick.sh: Error getting commits for PR 1966. Retrying
master-build-check-49: cherryPick.sh: Error getting commits for PR 1966. Retry failed.

@github-actions

github-actions Bot commented Jun 9, 2026

Copy link
Copy Markdown

Workflow Check completed successfully

@github-actions github-actions Bot added cherry-pick-testing-in-progress Cherry-Pick tests in progress and removed cherry-pick-test labels Sep 8, 2026
@asterisk asterisk deleted a comment from mbradeen Sep 8, 2026
@github-actions github-actions Bot added cherry-pick-checks-failed Cherry-Pick checks failed and removed cherry-pick-testing-in-progress Cherry-Pick tests in progress labels Sep 8, 2026
@github-actions

github-actions Bot commented Sep 8, 2026

Copy link
Copy Markdown

Workflow CPCheck failed
20-build-cpcheck-99: cherryPick.sh: Unable to cherry-pick commit 'Audiohooks: Allow whisper audiohooks to work without an underlying stream' to branch 20
23-build-cpcheck-99: cherryPick.sh: Unable to cherry-pick commit 'Audiohooks: Allow whisper audiohooks to work without an underlying stream' to branch 23
24-build-cpcheck-99: cherryPick.sh: Unable to cherry-pick commit 'Audiohooks: Allow whisper audiohooks to work without an underlying stream' to branch 24

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@jcolp jcolp jcolp approved these changes

Assignees

No one assigned

Labels

cherry-pick-checks-failed Cherry-Pick checks failed pr-submit-tests-passed

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@mbradeen @jcolp @gtjoseph