Feat/icons generation reproducibility check#716
Open
comfrt1k wants to merge 19 commits into
Open
Conversation
TorinAsakura
approved these changes
Jun 19, 2026
TorinAsakura
requested changes
Jun 19, 2026
TorinAsakura
left a comment
TorinAsakura
left a comment
Member
There was a problem hiding this comment.
кажется слой ui-admin/icons/scripts/ давно уже перерос в lib как минимум, нужна реорганизация
Contributor
Author
|
TorinAsakura
approved these changes
Jun 23, 2026
TorinAsakura
requested changes
Jun 23, 2026
TorinAsakura
left a comment
TorinAsakura
left a comment
Member
There was a problem hiding this comment.
Архитектурный контур не проходит: проверочный сценарий и роли файлов разложены не по владельцу ответственности
TorinAsakura
requested changes
Jun 23, 2026
TorinAsakura
requested changes
Jul 1, 2026
Comment on lines
+1
to
+5
| export const fileDriftStates = { | ||
| different: 'different', | ||
| missing: 'missing', | ||
| unexpected: 'unexpected', | ||
| } as const |
Member
There was a problem hiding this comment.
это не интерфейсы, а константы
что они тут делают?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Таска
Как проверять
Контекст: локальная проверка воспроизводимости генерации
@atls-ui-admin/iconsДействие: выполнить
yarn workspace @atls-ui-admin/icons check-generatedОжидаемый результат: команда завершается успешно, выводит
Generated icons are up to date, рабочее дерево после запуска остаётся чистымКонтекст: негативная проверка drift сгенерированных icon-компонентов
Действие: временно изменить любой файл в
ui-admin/icons/src/icons, например заменить одинcurrentColorвbag.icon.tsx, затем выполнитьyarn workspace @atls-ui-admin/icons check-generatedОжидаемый результат: команда падает с ошибкой
Generated files are outdatedи указывает изменённый файл какcontent differsКонтекст: сборка затронутых пакетов
Действие: выполнить
yarn workspace @atls-ui-admin/icons buildиyarn workspace @atls-ui-generators/icons buildОжидаемый результат: обе сборки завершаются успешно
Пруфы
Details