fix: code review fixes for oldest code files#6259
Open
JiayangLai wants to merge 1 commit intoavelino:mainfrom
Open
fix: code review fixes for oldest code files#6259JiayangLai wants to merge 1 commit intoavelino:mainfrom
JiayangLai wants to merge 1 commit intoavelino:mainfrom
Conversation
- Fix typo in main.go: 'midirAll' -> 'mkdirAll' in error message - Remove unnecessary capacity argument in main_test.go: make(map[string]bool, 0) -> make(map[string]bool) - Remove outdated FIXME comment in generator.go that suggested a change which would break existing tests These files were identified as the oldest code files in the repository (some not updated in 3+ years). Co-Authored-By: Claude <claude@example.com>
Automated Quality ChecksSkipped — this PR does not modify This is expected for maintenance, documentation, or workflow PRs. |
pkg/slug/generator_test.go - last updated Aug 2022 (3.5+ years ago) pkg/slug/generator.go - last updated Feb 2023 pkg/markdown/convert.go - last updated Feb 2023 pkg/markdown/convert_test.go - last updated Feb 2023 main_test.go - last updated Feb 2023 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Code review fixes for the 5 oldest code files in the repository (some not updated in 3+ years):
Changes Made
main.go: Fixed typo in error message
midirAlltomkdirAllmain_test.go: Removed unnecessary capacity argument
make(map[string]bool, 0)tomake(map[string]bool)makefor maps is capacity, and0is the defaultpkg/slug/generator.go: Removed outdated FIXME comment
regexp.Replacebut the suggested change would break existing testsstrings.ReplaceAllandslugify.Slugifycorrectly handles all test casesFiles Reviewed
The following oldest code files were identified and reviewed:
pkg/slug/generator_test.go- last updated Aug 2022 (3.5+ years ago)pkg/slug/generator.go- last updated Feb 2023pkg/markdown/convert.go- last updated Feb 2023pkg/markdown/convert_test.go- last updated Feb 2023main_test.go- last updated Feb 2023Test Plan
go test ./...to verify all tests passGenerated with Claude Code