Repository navigation
Allow configuring the default torch.compile backend - #12
Closed
ryan-li-ryanllli-aws wants to merge 2 commits into
Closed
ryan-li-ryanllli-aws wants to merge 2 commits into
ryan-li-ryanllli-aws wants to merge 2 commits into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
TORCHTITAN_COMPILE_BACKENDenvironment variable duringtorchtitan.tools.utilsinitializationtorch.compiler.set_default_backend(...)before attention and vision helpers bind backend-lesstorch.compilecallsUsage
An out-of-tree custom device integration only needs to set this value before launching TorchTitan. It does not need to wrap
torch.compile, patch TorchTitan, or install a TorchTitan-specific plugin entry point. Calls that explicitly passbackend=remain unaffected by PyTorch default-backend selection.Why this is early enough
torchtitan.models.common.attentionimportsround_upfromtorchtitan.tools.utilsbefore defining its class-level and module-level compiled helpers. The common vision encoder imports the attention module before defining its own compiled block-mask helper. Configuring the PyTorch default intools.utilstherefore covers all three import-time sites.Test plan
13 passedintests/unit_tests/cpu/tools/test_tools_utils.pygit diff --checkpassed