Repository navigation
fix(toolkit-lib): paginate stack resource drift results - #2028
Open
proton0210 wants to merge 1 commit into
Open
proton0210 wants to merge 1 commit into
proton0210 wants to merge 1 commit into
Conversation
1 task
proton0210
requested a deployment
to
integ-approval
October 8, 2026 06:33 — with
GitHub Actions
Waiting
aws-cdk-automation
enabled auto-merge
October 8, 2026 06:33
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #2028 +/- ##
==========================================
+ Coverage 91.96% 92.00% +0.03%
==========================================
Files 82 82
Lines 13138 13138
Branches 1864 1866 +2
==========================================
+ Hits 12083 12087 +4
+ Misses 1017 1013 -4
Partials 38 38
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
This branch is waiting to be deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issue
Closes #2026.
Change
detectStackDriftnow consumes everyDescribeStackResourceDriftspage before formatting results and counting drifted/unchecked resources. It follows continuation tokens even when a page has an empty or omitted resource list, preserves all statuses (includingUNKNOWN), and does not return an obsolete continuation token. A later-page API failure propagates instead of reporting partial success.This fixes false-negative
cdk drift --failresults for larger stacks without changing command options, formatting, IAM permissions, or single-page behavior.Validation
DELETED/UNKNOWNrecords, correct request tokens, warning output, and later-page failures.git diff --checkclean.No feature flag is proposed: incomplete API pagination is an erroneous result, not an intended alternate behavior.
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license