Skip to content

fix(toolkit-lib): warn on empty change sets for unsuccessful stacks - #2029

Open
proton0210 wants to merge 1 commit into
aws:mainfrom
proton0210:fix/no-change-failed-stack-warning
Open

proton0210 wants to merge 1 commit into
aws:mainfrom
proton0210:fix/no-change-failed-stack-warning

Conversation

@proton0210

Copy link
Copy Markdown
Contributor

Summary

  • Warn with the stack name and status when an empty change set leaves a stack outside a successful deployment state.
  • Suppress the misleading force-deployment claim that all resources are up to date in that case.
  • Preserve the no-op result, exit-code behavior, and change-set cleanup. This implements the warning-only first step suggested in cdk deploy reports "(no changes)" and exits 0 while the stack is still in UPDATE_FAILED #1972; it does not change failure exit codes or recovery behavior.

Related to #1972.

Validation

  • Toolkit library and test TypeScript compilation passed.
  • Deployment stack suite: 100 tests and 1 snapshot passed, including six new cases covering UPDATE_FAILED with/without force, all three successful statuses, and no-execute cleanup after rollback.
  • Scoped ESLint and git diff --check passed.
  • Three audit passes covered scope/backward compatibility, status and cleanup edge cases, and the final diff/regression suite.
  • No live AWS deployment was performed; the regression tests use the existing fake CloudFormation implementation.

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license

@codecov-commenter

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 92.00%. Comparing base (13877dc) to head (4ec6593).

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #2029      +/-   ##
==========================================
+ Coverage   91.96%   92.00%   +0.03%     
==========================================
  Files          82       82              
  Lines       13138    13138              
  Branches     1864     1867       +3     
==========================================
+ Hits        12083    12087       +4     
+ Misses       1017     1013       -4     
  Partials       38       38              
Flag Coverage Δ
suite.unit 92.00% <ø> (+0.03%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

This branch is waiting to be deployed

1 active and 1 waiting deployments
integ-approval — 4ec6593c Waiting Oct 8, 2026 by proton0210 via prepare #7123
automation — 4ec6593c Deployed Oct 8, 2026 by proton0210 via Triage Pull Requests #2180
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants