Repository navigation
fix(cli): pass CloudFormation parameters to diff change sets - #2030
Open
proton0210 wants to merge 1 commit into
Open
proton0210 wants to merge 1 commit into
proton0210 wants to merge 1 commit into
Conversation
proton0210
had a problem deploying
to
automation
October 8, 2026 07:01 — with
GitHub Actions
Failure
1 task
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #2030 +/- ##
==========================================
+ Coverage 91.96% 92.07% +0.10%
==========================================
Files 82 82
Lines 13138 13146 +8
Branches 1864 1870 +6
==========================================
+ Hits 12083 12104 +21
+ Misses 1017 1004 -13
Partials 38 38
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
proton0210
marked this pull request as ready for review
October 8, 2026 07:40
mrgrain
approved these changes
Oct 8, 2026
This branch had an error being deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes #1995 by defining --parameters for cdk diff and passing parsed values through the existing parameter-aware change-set path. Global KEY=VALUE and STACK:KEY=VALUE behave as in deploy, including stack-specific overrides. Diff and deploy share their unchanged parsing logic.
Template-only comparisons reject explicit parameters rather than silently ignoring them. Documentation describes parameter precedence, existing omitted-value behavior, and the auto-method fallback limitation; use --method=change-set when parameter-aware output is required. CLI parser/types/registry were regenerated with the repository generator.
Validation
Draft until that integration regression has been run in a disposable AWS account. No live AWS test was performed, and no live behavior or timing is claimed.Test is running as part of the PR.By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license