Skip to content

fix(cli): pass CloudFormation parameters to diff change sets - #2030

Open
proton0210 wants to merge 1 commit into
aws:mainfrom
proton0210:fix/diff-cloudformation-parameters
Open

proton0210 wants to merge 1 commit into
aws:mainfrom
proton0210:fix/diff-cloudformation-parameters

Conversation

@proton0210

@proton0210 proton0210 commented Oct 8, 2026 •

Copy link
Copy Markdown
Contributor

Summary

Fixes #1995 by defining --parameters for cdk diff and passing parsed values through the existing parameter-aware change-set path. Global KEY=VALUE and STACK:KEY=VALUE behave as in deploy, including stack-specific overrides. Diff and deploy share their unchanged parsing logic.

Template-only comparisons reject explicit parameters rather than silently ignoring them. Documentation describes parameter precedence, existing omitted-value behavior, and the auto-method fallback limitation; use --method=change-set when parameter-aware output is required. CLI parser/types/registry were regenerated with the repository generator.

Validation

  • CLI and integration-test TypeScript compilation passed.
  • 107 tests passed across diff options, deploy options, diff command and argument parsing.
  • Scoped ESLint and git diff --check passed.
  • Three audit passes covered scope/parser compatibility, precedence and fallback semantics, and final generated files/regressions.
  • Added a live integration regression using the existing parameterized SNS fixture: matching values yield no changes, different values show a resource diff.

Draft until that integration regression has been run in a disposable AWS account. No live AWS test was performed, and no live behavior or timing is claimed. Test is running as part of the PR.

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license

@codecov-commenter

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 92.07%. Comparing base (13877dc) to head (b9115db).

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #2030      +/-   ##
==========================================
+ Coverage   91.96%   92.07%   +0.10%     
==========================================
  Files          82       82              
  Lines       13138    13146       +8     
  Branches     1864     1870       +6     
==========================================
+ Hits        12083    12104      +21     
+ Misses       1017     1004      -13     
  Partials       38       38              
Flag Coverage Δ
suite.unit 92.07% <100.00%> (+0.10%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@proton0210
proton0210 marked this pull request as ready for review October 8, 2026 07:40

This branch had an error being deployed

1 failed and 2 active deployments
integ-approval — b9115db5 Deployed Oct 8, 2026 by proton0210 via prepare #7124
automation — b9115db5 Deployed Oct 8, 2026 by proton0210 via Set AutoQueue on PR #2030 #3708
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

cdk diff: ignores cloudformation parameters

3 participants