Skip to content

ci: fix stale cliff.toml remote owner (awslabs -> aws)#747

Open
JamBalaya56562 wants to merge 1 commit into
aws:mainfrom
JamBalaya56562:fix-changelog-workflow
Open

ci: fix stale cliff.toml remote owner (awslabs -> aws)#747
JamBalaya56562 wants to merge 1 commit into
aws:mainfrom
JamBalaya56562:fix-changelog-workflow

Conversation

@JamBalaya56562
Copy link
Copy Markdown
Contributor

@JamBalaya56562 JamBalaya56562 commented May 31, 2026

Summary

Fix the stale cliff.toml GitHub remote owner so git-cliff's API enrichment resolves correctly.

 [remote.github]
-owner = "awslabs"
+owner = "aws"
 repo = "aws-lambda-web-adapter"

The repo lives at aws/aws-lambda-web-adapter, not awslabs/..., so the old value pointed git-cliff's GitHub API lookups (PR / author enrichment) at the wrong owner.

Scope change

This PR originally also reworked the Changelog workflow to open a PR instead of pushing to the protected main branch. Per maintainer feedback, the release pipeline will instead be refactored using release-plz, so that workflow rework is dropped here.

The PR is now narrowed to the single obvious cliff.toml fix, leaving the broader release-pipeline redesign to the release-plz effort.

@JamBalaya56562 JamBalaya56562 force-pushed the fix-changelog-workflow branch from 90226ba to fdb45a4 Compare May 31, 2026 14:53
@bnusunny
Copy link
Copy Markdown
Contributor

bnusunny commented Jun 1, 2026

I also saw this pipeline issue. I would prefer to use release-plz action to refactor the release pipeline.

git-cliff's GitHub API enrichment was pointed at the wrong owner
(awslabs/aws-lambda-web-adapter), which 404s. Correct it to
aws/aws-lambda-web-adapter so PR/author links resolve.

Scope note: this PR originally also reworked the Changelog workflow to
open a PR instead of pushing to protected main, but per maintainer
feedback the release pipeline will be refactored with release-plz
instead, so this PR is narrowed to the one obvious cliff.toml fix.

Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
@JamBalaya56562 JamBalaya56562 force-pushed the fix-changelog-workflow branch from fdb45a4 to 3529758 Compare June 2, 2026 00:27
@JamBalaya56562 JamBalaya56562 changed the title ci: open a changelog PR instead of pushing to protected main ci: fix stale cliff.toml remote owner (awslabs -> aws) Jun 2, 2026
@JamBalaya56562
Copy link
Copy Markdown
Contributor Author

Thanks for the steer, @bnusunny — agreed that moving the release pipeline to release-plz is the better long-term direction, so I'll leave that refactor to you rather than reworking the workflow here.

I've narrowed this PR down to just the one obvious fix: the stale cliff.toml remote owner (awslabsaws), which points git-cliff's GitHub API enrichment at the correct repo. The changelog.yaml workflow changes have been dropped so they don't conflict with the release-plz migration.

JamBalaya56562 added a commit to JamBalaya56562/aws-lambda-web-adapter that referenced this pull request Jun 2, 2026
Replace the manual bump/tag/changelog release process with release-plz
(https://release-plz.dev), per maintainer feedback on aws#747.

Flow: on push to main, release-plz opens a Release PR that bumps the
Cargo.toml version and updates CHANGELOG.md (reusing the existing
cliff.toml via changelog_config). Merging that PR creates the v<version>
git tag, publishes a GitHub Release, and runs cargo publish.

Key details:
- Uses a GitHub App token (actions/create-github-app-token), NOT the
  default GITHUB_TOKEN. This is required so the GitHub Release created by
  release-plz triggers release.yaml (on: release: types: [released]) --
  the default token cannot trigger other workflows, which would silently
  skip the layer build / deploy / Docker publish.
- Re-enables crates.io publishing (the crate was left at 0.9.1 while the
  repo moved to 1.0.x because the manual process forgot to publish). Auth
  via crates.io trusted publishing (OIDC), no long-lived token.
- Deletes the changelog.yaml workflow, now superseded by release-plz.

Maintainer prerequisites are documented in release-plz.yml: enable
'Allow GitHub Actions to create and approve pull requests', install a
GitHub App (Contents + Pull requests R/W) and set RELEASE_PLZ_APP_ID /
RELEASE_PLZ_APP_PRIVATE_KEY, and register the crates.io trusted publisher.

RELEASE_PLZ_NOTES.md is temporary research context and will be removed
before merge.

Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
JamBalaya56562 added a commit to JamBalaya56562/aws-lambda-web-adapter that referenced this pull request Jun 2, 2026
Replace the manual bump/tag/changelog release process with release-plz
(https://release-plz.dev), per maintainer feedback on aws#747.

Flow: on push to main, release-plz opens a Release PR that bumps the
Cargo.toml version and updates CHANGELOG.md (reusing the existing
cliff.toml via changelog_config). Merging that PR creates the v<version>
git tag, publishes a GitHub Release, and runs cargo publish.

Key details:
- Uses a GitHub App token (actions/create-github-app-token), NOT the
  default GITHUB_TOKEN. This is required so the GitHub Release created by
  release-plz triggers release.yaml (on: release: types: [released]) --
  the default token cannot trigger other workflows, which would silently
  skip the layer build / deploy / Docker publish.
- Re-enables crates.io publishing (the crate was left at 0.9.1 while the
  repo moved to 1.0.x because the manual process forgot to publish). Auth
  via crates.io trusted publishing (OIDC), no long-lived token.
- Deletes the changelog.yaml workflow, now superseded by release-plz.

Maintainer prerequisites are documented in release-plz.yml: enable
'Allow GitHub Actions to create and approve pull requests', install a
GitHub App (Contents + Pull requests R/W) and set RELEASE_PLZ_APP_ID /
RELEASE_PLZ_APP_PRIVATE_KEY, and register the crates.io trusted publisher.

RELEASE_PLZ_NOTES.md is temporary research context and will be removed
before merge.

Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
JamBalaya56562 added a commit to JamBalaya56562/aws-lambda-web-adapter that referenced this pull request Jun 2, 2026
Replace the manual bump/tag/changelog release process with release-plz
(https://release-plz.dev), per maintainer feedback on aws#747.

Flow: on push to main, release-plz opens a Release PR that bumps the
Cargo.toml version and updates CHANGELOG.md (reusing the existing
cliff.toml via changelog_config). Merging that PR creates the v<version>
git tag, publishes a GitHub Release, and runs cargo publish.

Key details:
- Uses a GitHub App token (actions/create-github-app-token), NOT the
  default GITHUB_TOKEN. This is required so the GitHub Release created by
  release-plz triggers release.yaml (on: release: types: [released]) --
  the default token cannot trigger other workflows, which would silently
  skip the layer build / deploy / Docker publish.
- Re-enables crates.io publishing (the crate was left at 0.9.1 while the
  repo moved to 1.0.x because the manual process forgot to publish). Auth
  via crates.io trusted publishing (OIDC), no long-lived token.
- Deletes the changelog.yaml workflow, now superseded by release-plz.

Maintainer prerequisites are documented in release-plz.yml: enable
'Allow GitHub Actions to create and approve pull requests', install a
GitHub App (Contents + Pull requests R/W) and set RELEASE_PLZ_APP_ID /
RELEASE_PLZ_APP_PRIVATE_KEY, and register the crates.io trusted publisher.

RELEASE_PLZ_NOTES.md is temporary research context and will be removed
before merge.

Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants