Fix flakey integ test by adding params#7146
Open
RanVaknin wants to merge 1 commit into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Context
testExceptionHandlinginteg test in the Cloudwatch test package was flakey because the service was returning a non deterministic exception. We expected it to returnMissingRequiredParameterExceptionexception but it sometimes returnedInvalidParameterCombinationexception instead.I was able to reproduce it by running test case repeatedly 100 times, seeing the following:
79/100
MissingParameter21/100
InvalidParameterCombinationFix
The fix adds all the other required fields, except for
MetricName. Resulted in deterministic 100/100MissingParameterexception.