feat: add option to allow different algos to sign Cloudfront#3315
Open
guidopili-docebo wants to merge 1 commit into
Open
feat: add option to allow different algos to sign Cloudfront#3315guidopili-docebo wants to merge 1 commit into
guidopili-docebo wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Addresses Issue #3116
Summary
CloudFront's Signer, CookieSigner, UrlSigner, and the CloudFrontClient convenience methods previously hardcoded SHA1 as the signing algorithm (the openssl_sign() default). This change adds an optional $algorithm parameter so callers can pass any OpenSSL-supported algorithm, such as SHA256.
Changes
$algorithmproperty (fourth constructor parameter, defaults toOPENSSL_ALGO_SHA1). Passed through toopenssl_sign().getSignedUrl()andgetSignedCookie()read an optional'algorithm'key from the options array and forward it to the respective signer.OPENSSL_ALGO_SHA256produces a valid, URL-safe signature that differs from the SHA1 output.Backward compatibility
Fully backward compatible. All new parameters default to
OPENSSL_ALGO_SHA1, which matches the previous implicit behavior.Usage