Repository navigation
fix: preserve ANY routes when merging API definitions - #4004
Open
proton0210 wants to merge 1 commit into
Open
proton0210 wants to merge 1 commit into
proton0210 wants to merge 1 commit into
Conversation
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issue #, if available
Closes #4000. Thanks to @tiagohconte for the reproduction and proposed fix.
Description of changes
With
MergeDefinitions: true, SAM writesANYevents underanyinstead ofx-amazon-apigateway-any-method. It also drops generated routes when the inlinepathsis empty, null or missing.Use the normalized method name for both lookup and write-back, and retain the paths dictionary in the merged body. Existing inline fields are preserved while SAM's generated integration takes precedence. Correcting the API body changes the deployment hash for affected templates.
Description of how you validated changes
make pron Python 3.12: all checks passed, 4,672 tests passed, 95.63% coverage.No live AWS deployment was run.
Checklist
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.