test(spend-permission): add coverage for fetchPermission#360
Open
anilkaracay wants to merge 1 commit into
Open
test(spend-permission): add coverage for fetchPermission#360anilkaracay wants to merge 1 commit into
anilkaracay wants to merge 1 commit into
Conversation
Collaborator
🟡 Heimdall Review Status
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
fetchPermission.ts(spend-permission utility) had no co-located test coverage,unlike its sibling
fetchPermissions.ts(plural), which has full tests.Change
Adds
fetchPermission.test.tswith characterization tests for the existing behavior.No production code is changed. Tests mirror the conventions of the existing
fetchPermissions.node.test.ts(same mocking of:util/provider.js, provider stub,assertion style) and import the wrapped export.
Coverage:
coinbase_fetchPermissionrequest and unwrapped.permissionresult; error propagationfetchRPCRequesttoCB_WALLET_RPC_URL; error propagation.permission; handles a minimal permissiondocumenting today's behavior, not asserting it is correct):
nullresponse rejects;response without a
permissionkey resolvesundefinedTesting
.../spend-permission/methods/fetchPermission.test.tsyarn test --run: full suite green (account package 74 files / 1010 tests)yarn format: clean (Biome)yarn build:packages: type-checksNotes
Tests only. The malformed-response cases are characterization tests documenting current
behavior for future reference; they do not change any behavior.