Repository navigation
M1: add Model, List, Component with deprecated LEO aliases - #31
Merged
Merged
Conversation
basiclines
commented
Nov 6, 2026
basiclines
left a comment
Owner
Author
There was a problem hiding this comment.
Reviewer verdict: ready (head 7be0e3f; builder revision not stated on the PR).
- CI: both
testchecks SUCCESS; mergeable CLEAN, base master. - Local:
npm test55 passing at this head. - Mutation spot-check: removing the deprecated alias export makes the alias identity test fail (54 pass, 1 fail); restored, 55 pass.
- Scope: first unchecked milestone M1 (rename with aliases). Model/List/Component exported, LEOObject/LEOList/LEOElement kept as same-class deprecated aliases, no removal, no release/version change, no perf or size claims. Docs/README and committed dist regenerated per current policy.
- Gaps: none blocking. Remaining M1 items (TS, tsup/Vite, Vitest, JSX runtime, drop dist) stay pending, so M1 is not checked.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Roadmap: #30, M1 Stack + naming, slice "rename with aliases".
What changed
src/leo.jsexportsModel,List,Component;LEOObject,LEOList,LEOElementstay as deprecated aliases (same classes, soinstanceofand subclassing keep working).readme.templateuses the new names and notes the aliases; README anddist/regenerated (npm run dist). Examples keep the old names on purpose (alias coverage) and their built bundles were rebuilt.Tests (written first)
tests/unit/aliases_tests.js: new names exported, aliases are strictly equal to the new names,ListinstanceofModel. Failed 3/3 before the change.Mutation evidence
Checks run locally
npm test(55 pass),npm run dist,npm run build:examples && npm run test:examplespassed.Pending (rest of M1)
TypeScript move, tsup/Vite, Vitest, automatic JSX runtime, drop polyfills and committed dist. No size or performance numbers claimed.