Repository navigation
Pass progress estimates as seconds and write them without a space - #165
Merged
Merged
Conversation
bboe
force-pushed
the
estimate-spacing
branch
2 times, most recently
from
November 12, 2026 09:54
e8a6933 to
ba37849
Compare
bboe
changed the title
A step's estimate read "~40 s" while its elapsed time and the total read "24s" and "2m 03s total". Each caller built the estimate as a string, so the display lived in some 75 call sites. The estimate is now an int of seconds, and Progress.begin alone writes it, as "~40s". The label column takes the character that frees, 43 wide where it was 42. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
bboe
force-pushed
the
estimate-spacing
branch
from
November 12, 2026 09:58
ba37849 to
d815836
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Progress estimates read "~40 s" while elapsed times and totals read "24s". Callers now pass the estimate as seconds, and the progress line alone writes it, as "~40s". The label column gains the character that frees.
🤖 Generated with Claude Code