fix: fixes QueryParser parsing of dasherized/camelized filter keys#434
Merged
Merged
Conversation
QueryParser parsing of dasherized/camelized filter keys
mattpolzin
approved these changes
Jun 3, 2026
Member
There was a problem hiding this comment.
I'm more on the fence about this one because there was a way to get this behavior at least and it constitutes what could be a breaking change for folks but on the grounds that this brings filter query parameters in line with all other query parameter handling I think it is worth accepting nonetheless.
I'd argue for this being part of a v2 release, but I don't have time to put that release together (which should involve revisiting a handful of other deferred breaking changes) so we can move forward with this as a minor patch release.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Analogous to #431 but for
filter.QueryParseris already automatically underscoringfields,sortandinclude, just missingfilter.Seems this would be the last fix needed to "close" Standardize on underscoring query parameters #285.
Underscoring of
filterkeys is technically already supported byUnderscoreParametersplug, but it feels that this should work for anyone usingQueryParserand notUnderscoreParametersplug.I kind of agree with the following statement by @TylerPachal statement in #285