Skip to content

fix: fixes QueryParser parsing of dasherized/camelized filter keys#434

Merged
mattpolzin merged 2 commits into
beam-community:mainfrom
mimiquate:fix-filter-underscore
Jun 3, 2026
Merged

fix: fixes QueryParser parsing of dasherized/camelized filter keys#434
mattpolzin merged 2 commits into
beam-community:mainfrom
mimiquate:fix-filter-underscore

Conversation

@grzuy
Copy link
Copy Markdown
Contributor

@grzuy grzuy commented May 22, 2026

Analogous to #431 but for filter.

QueryParser is already automatically underscoring fields, sort and include, just missing filter.

Seems this would be the last fix needed to "close" Standardize on underscoring query parameters #285.


Underscoring of filter keys is technically already supported by UnderscoreParameters plug, but it feels that this should work for anyone using QueryParser and not UnderscoreParameters plug.

I kind of agree with the following statement by @TylerPachal statement in #285

I think for version 2.0 of this library:

All of the query parameters should always be underscored. It should be done by the QueryParser module.
The UnderscoreParameters module should go back to just doing the params, mostly undoing the work in #282.

@grzuy grzuy requested a review from a team as a code owner May 22, 2026 18:35
@grzuy grzuy changed the title fix: fixes parsing of filter keys with dashes/camelized with QueryParser fix: fixes parsing of dasherized/camelized filter keys with QueryParser May 22, 2026
@grzuy grzuy changed the title fix: fixes parsing of dasherized/camelized filter keys with QueryParser fix: fixes QueryParser parsing of dasherized/camelized filter keys May 22, 2026
Copy link
Copy Markdown
Member

@mattpolzin mattpolzin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm more on the fence about this one because there was a way to get this behavior at least and it constitutes what could be a breaking change for folks but on the grounds that this brings filter query parameters in line with all other query parameter handling I think it is worth accepting nonetheless.

I'd argue for this being part of a v2 release, but I don't have time to put that release together (which should involve revisiting a handful of other deferred breaking changes) so we can move forward with this as a minor patch release.

@mattpolzin mattpolzin merged commit dba3d40 into beam-community:main Jun 3, 2026
9 of 10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants