Repository navigation
[UPDATE][mindwtr][1.1.7] Upgrade Mindwtr 1.3.7 to 1.3.8 - #3916
Merged
Merged
Conversation
- chart version 1.1.6 -> 1.1.7; appVersion / versionName -> 1.3.8; values tag -> 1.3.8 - templates reference .Values.image.tag, so no template change is needed - the tag must be a new value: imagePullPolicy is IfNotPresent and reusing a tag would not pull the new layers - verified the rebuilt 1.3.8 image inherits the earlier fixes: WorkingDir is /app, the Entrypoint and the full Env set are identical to 1.3.7-r2, and the image.version label reads 1.3.8 - prepend v1.1.7 notes to upgradeDescription in root, en-US and zh-CN; the existing three-file entry counts were already uneven before this change (root had 10, i18n had 2), left as-is to keep the diff to this upgrade
Collaborator
|
Check passed, please wait for auto-merge. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Upgrade Mindwtr from
1.3.7to1.3.8in the Olares appmindwtr, chart version1.1.6->1.1.7.This app uses a self-built merged image (
ghcr.io/inverstar/mindwtr-merged), so the version bump had to be verified against the actual image config rather than just the upstream tag.Changes (5 files, +42 −6)
Chart.yamlversion: 1.1.6 -> 1.1.7,appVersion: 1.3.7 -> 1.3.8OlaresManifest.yamlmetadata.version -> 1.1.7,spec.versionName -> 1.3.8, prependv1.1.7notesi18n/en-US+i18n/zh-CNv1.1.7notesvalues.yamltag: "1.3.7-r2" -> "1.3.8", update the tag commentNo template change:
templates/mindwtr.yamluses{{ .Values.image.tag | default .Chart.AppVersion }}, sovalues.yamlis the single source of truth here.Image verification (important for this app)
The tag is new by necessity —
imagePullPolicy: IfNotPresentmeans reusing a tag will not pull new layers.1.3.7had to be rebuilt twice (-r2,-r3) because of a brokenWORKDIRand a missingMINDWTR_CLOUD_CORS_ORIGINdefault. So1.3.8was checked against the registry config blob:1.3.7-r21.3.8WorkingDir/app/appEntrypoint/usr/local/bin/mindwtr-merged-startEnv(full set)image.versionlabelThe earlier fixes are inherited, so no chart-side change is needed.
What 1.3.8 contains
No breaking change announced.
Note on
upgradeDescriptionentry countsThe three files already had different entry counts before this change (root: 10, en-US: 2, zh-CN: 2). This PR adds one entry to each (11 / 3 / 3) and deliberately does not backfill the missing history, to keep the diff scoped to this upgrade.