Skip to content

Drop support for python 3.8 #754

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
benfred merged 1 commit into from
May 7, 2026
Merged

Drop support for python 3.8 #754

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions .github/workflows/build.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -28,7 +28,7 @@ jobs:
strategy:
matrix:
os: [macos-latest, ubuntu-latest, windows-latest, ubuntu-24.04-arm]
python-version: [38, 39, 310, 311, 312, 313, 314]
python-version: [39, 310, 311, 312, 313, 314]

steps:
- uses: actions/checkout@v6
Expand Down Expand Up @@ -60,7 +60,7 @@ jobs:
runs-on: ${{ matrix.os }}
strategy:
matrix:
python-version: [3.8, 3.9, '3.10', '3.11', '3.12', '3.13', '3.14']
python-version: [3.9, '3.10', '3.11', '3.12', '3.13', '3.14']
os: [macos-latest, ubuntu-latest, windows-latest, ubuntu-24.04-arm]

steps:
Expand Down
2 changes: 1 addition & 1 deletion implicit/gpu/matrix.pxd
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -21,7 +21,7 @@ cdef extern from "implicit/gpu/matrix.h" namespace "implicit::gpu" nogil:
Matrix(const Matrix & other, size_t rowid) except +
Matrix(const Matrix & other, size_t start, size_t end) except +
Matrix(const Matrix & other, const Vector[int] & rowids) except +
Matrix(Matrix && other) except +
Matrix(Matrix & other) except +
void to_host(void * output) except +
void resize(size_t rows, size_t cols) except +
void assign_rows(const Vector[int] & rowids, const Matrix & other) except +
Expand Down
2 changes: 1 addition & 1 deletion pyproject.toml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -16,7 +16,7 @@ readme = "README.md"
authors = [
{ name = "Ben Frederickson", email = "ben@benfrederickson.com" },
]
requires-python = ">=3.8"
requires-python = ">=3.9"
license = "MIT"
license-files = ["LICENSE"]
classifiers = [
Expand Down
Loading