Skip to content

clip_check_recursive fix#24684

Merged
alice-i-cecile merged 3 commits into
bevyengine:mainfrom
ickshonpe:ui-text-picking-fix-again
Jun 22, 2026
Merged

clip_check_recursive fix#24684
alice-i-cecile merged 3 commits into
bevyengine:mainfrom
ickshonpe:ui-text-picking-fix-again

Conversation

@ickshonpe

Copy link
Copy Markdown
Contributor

Objective

clip_check_recursive stops at the first unclipped ancestor when it should progress all the way to the root element unless the given point is clipped.

Fixes #24680

Solution

Early return if the entity is a root.
Then check if the point is clipped and if so return false.
Otherwise recurse to next ancestor.

Testing

cargo run --example feathers_gallery --features="bevy_feathers"

The scrolling list should no long block the x text input when scrolled all the way down.

…ather than progressing all the way to the root element.

Instead early return if the node is a root. Then check if the point is clipped and if so return false. Then recurse to next ancestor.
@ickshonpe ickshonpe added the A-UI Graphical user interfaces, styles, layouts, and widgets label Jun 20, 2026
@github-project-automation github-project-automation Bot moved this to Needs SME Triage in UI Jun 20, 2026
@ickshonpe ickshonpe added A-Picking Pointing at and selecting objects of all sorts C-Bug An unexpected or incorrect behavior P-Regression Functionality that used to work but no longer does. Add a test for this! D-Straightforward Simple bug fixes and API improvements, docs, test and examples S-Needs-Review Needs reviewer attention (from anyone!) to move forward labels Jun 20, 2026
@ickshonpe ickshonpe changed the title clip_check_recursive was stopping at the first unclipped ancestor r… clip_check_recursive fix Jun 20, 2026
@ickshonpe ickshonpe added this to the 0.19.1 milestone Jun 21, 2026
@kfc35 kfc35 requested a review from alice-i-cecile June 22, 2026 15:02
@kfc35

kfc35 commented Jun 22, 2026

Copy link
Copy Markdown
Contributor

This fixes the bug for me

@alice-i-cecile alice-i-cecile added S-Ready-For-Final-Review This PR has been approved by the community. It's ready for a maintainer to consider merging it and removed S-Needs-Review Needs reviewer attention (from anyone!) to move forward labels Jun 22, 2026
@alice-i-cecile alice-i-cecile added this pull request to the merge queue Jun 22, 2026
Merged via the queue into bevyengine:main with commit 931b9d9 Jun 22, 2026
40 checks passed
@github-project-automation github-project-automation Bot moved this from Needs SME Triage to Done in UI Jun 22, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

A-Picking Pointing at and selecting objects of all sorts A-UI Graphical user interfaces, styles, layouts, and widgets C-Bug An unexpected or incorrect behavior D-Straightforward Simple bug fixes and API improvements, docs, test and examples P-Regression Functionality that used to work but no longer does. Add a test for this! S-Ready-For-Final-Review This PR has been approved by the community. It's ready for a maintainer to consider merging it

Projects

Status: Done

Development

Successfully merging this pull request may close these issues.

UI picking regression, cursor is blocked by scrollarea content that should be clipped

3 participants