feat(scroll): change scroll dt to_pixels#24731
Merged
Merged
Conversation
kfc35
approved these changes
Jun 27, 2026
kfc35
left a comment
Contributor
There was a problem hiding this comment.
This makes sense to me since scroll_pos is in logical pixels as you mentioned
I tested this using a mac trackpad and scrolling still seems fine.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Objective
Fixes #24610
Solution
-current scroll conversion ratio after
to_lines()was yielding 1px per notch for mousewheel scroll delta. It was converting scroll dt to line values then applying them toscroll_pos.y- which could be pixels instead.-So I changed to
to_pixels(). This applied to scroll dt yields 100px per notch .Testing
-
cargo run --example scrollis visually snappier. I'd be happy to provide comparison demo gifs if y'all want.-Could tweak notch speed via
MouseScrollPixelsPerLine