feat(account): PAYMENTS-11910 Create Add payment method page - #3187
Draft
Tharaae wants to merge 5 commits into
Draft
feat(account): PAYMENTS-11910 Create Add payment method page#3187Tharaae wants to merge 5 commits into
Tharaae wants to merge 5 commits into
Conversation
… account payments microapp component
🦋 Changeset detectedLatest commit: c836715 The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
Contributor
Bundle Size ReportComparing against baseline from
Per-Route First Load JS
|
Contributor
Unlighthouse Performance Comparison — VercelComparing PR preview deployment Unlighthouse scores vs production Unlighthouse scores. Summary ScoreAggregate score across all categories as reported by Unlighthouse.
Category Scores
Core Web Vitals
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What/Why?
This is to create a new path for "Add payment method" on shopper's account. It uses the
storefront-account-paymentsmicroapp as an embedded form to add a new payment method. It should use the following graphQL endpoints:Also, the route for the "stored payment methods" page (that will be implemented later) is assumed to be
/account/payment-methodsin this draft and a dummy page is created (the last commit) only for the sake of proof of concept and will not be merged.Testing
Screen record
https://github.com/user-attachments/assets/232b34f2-f281-4cae-8ef1-5c13cfd95acb
Migration
This is a whole new route that will stay as a dead-end with not entry point until the payment methods list page is created. This is why it's pushed in a separate feature branch.