Skip to content

cflib2: Lighthouse tab basic functionalities - #837

Draft
ArisMorgens wants to merge 5 commits into
cflib2from
Aris/cflib2/lighthouse-tab
Draft

ArisMorgens wants to merge 5 commits into
cflib2from
Aris/cflib2/lighthouse-tab

Conversation

@ArisMorgens

Copy link
Copy Markdown
Member

This PR adds the basic functionalities of the Lighthouse Positioning tab to the cflib2-based cfclient. The geometry-estimation-related features are not part of this PR, as we first need to decide on where the helper files should be hosted.

This PR is based on this cflib2 PR.

Differences compared to master:

  • A bad config file shows a pop up error instead of a traceback in the console.
  • You get a warning for rejected geometry and when saving to permanent memory fails. Master ignored both.
  • Only slots that were written are persisted. The effect on the drone is the same.
  • Import and Export are disabled while one is running.
  • Memory accesses take turns, since 2 users can't access it at the same time.
  • In the 3D view, the rotation comes from a new small function _rpy_to_rot. On master, this was done with cflib's Pose.from_cf_rpy().

The added files are formatted according to pre-commit.

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant