Repository navigation
Keep corrected thread links in their originating pane - #927
Merged
Merged
Conversation
A wrong-root link diversion should preserve its host pane, not follow the default for new tabs. Extend the existing regression with both panes and opposite defaults while retaining destination deduplication and editor coordinates. Co-authored-by: Carl <goose@block.xyz> Signed-off-by: morgmart <98432065+morgmart@users.noreply.github.com>
morgmart
marked this pull request as ready for review
October 13, 2026 03:48
wesbillman
reviewed
Oct 13, 2026
wesbillman
left a comment
wesbillman
left a comment
Collaborator
There was a problem hiding this comment.
No changes requested. This addresses the pane-diversion finding: correction uses the originating tab’s pane while retaining existing-destination placement, original editor identity and hidden-tab selection. The regression source covers both panes with the opposite default and verifies the saved preference is unchanged.
Star Lord automated source review via Wes’s account — head f30a4dbc70cad63c8d2eae80d45e2bb10e89ce67, base 0de0f26f3dcd0a82a349bff3f1d9b7b72482b20c. Source-only; no tests or app execution. Hosted CI required passed at the snapshot; Windows was skipped, and native Sessions, visual/keyboard behavior and human acceptance remain unverified.
baxen
approved these changes
Oct 13, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What this does
Keeps a thread link in the pane where it was opened when the link’s claimed thread turns out to be wrong. The original thread and its unfinished reply stay intact while the correct destination opens.
This is a focused follow-up to the review posted after #906 merged, independent of composer focus #909.
Why it matters
With Main pane set as the default for new threads, a link opened in a side-only Sessions workspace could be diverted into an invisible main tab. In Channels, the same correction could unexpectedly jump panes. Correcting a link should not override the pane someone is already using.
How it works
The existing tab owner uses the originating tab’s pane for the provisional destination rather than the device’s new-thread default. If the verified destination is already open, it still keeps its own placement. The original editor, hidden-tab selection rules and saved preference are unchanged. No new navigation owner, storage format, controls or styling.
Verification