Conversation
NVCC doesn't accept `Array<int, ArrayData<int>>` as `C<scalar>` so treats ConvertContainer<Array...> as partially specialized. This explicitly writes convertors for Array, Matrix and Tensor containers.
fmt uses `begin` rather than `std::begin` so that NVCC fails to find an overload for `char[]` literals.
Calls `Array::size()` that accesses a shared pointer to `ArrayData`. Doesn't need to be a device function since called outside kernel.
- Remove default arguments for fv_ops specializations - Use base class functions rather than partial overload
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
ZedThree
requested changes
Jul 21, 2026
ZedThree
left a comment
ZedThree
left a comment
Member
There was a problem hiding this comment.
Looks good, we can fix the clang-tidy warnings though
Co-authored-by: Peter Hill <zed.three@gmail.com>
Rather than returning incorrect values, mark code as unreachable. When C++23 is used, this can be replaced with std::unreachable.
ZedThree
approved these changes
Aug 5, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The NVidia C++ compiler is quite picky compared to LLVM and GCC.
These fixes enable compilation with nvcc V12.9.41 on Perlmutter.
Ready for merging.