Ensure option names updated to match path - #3445
Merged
Merged
Conversation
ZedThree
approved these changes
Jul 29, 2026
Collaborator
Author
|
Thanks for the speedy turnaround on this, but unfortunately I just realised there is a corner-case I missed. I'll open another PR for that. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Previously, using the move-assignment operator for
Optionsobjects would keep the same full name as the moved object. This was problematic because it meant that the name of the newly-assignedOptionsobject could differ from the path used to access that object. E.g.,This posed particular problems for the permissions system in Hermes-3, as it meant that the name being checked against permissions could be incorrect.
In this PR I've modified the move-assignment operator to ensure that the assigned-to
Optionsobject (and all children) will have names consistent with the path to access them.